update-pr-from-base-branch - Improve reliability#8831
Merged
fregante merged 1 commit intorefined-github:mainfrom Jan 3, 2026
Merged
update-pr-from-base-branch - Improve reliability#8831fregante merged 1 commit intorefined-github:mainfrom
update-pr-from-base-branch - Improve reliability#8831fregante merged 1 commit intorefined-github:mainfrom
Conversation
github-actions
bot
changed the title
github-actions
bot
changed the title
update-pr-from-base-branch
biplavbarua
force-pushed
the
fix/pr-update-button-selector
branch
from
85e23a0 to
2852786
Compare
biplavbarua
force-pushed
the
fix/pr-update-button-selector
branch
from
2852786 to
1d6aaac
Compare
fregante
approved these changes
Dec 23, 2025
fregante
changed the title
update-pr-from-base-branchupdate-pr-from-base-branch - Improve reliability
fregante
approved these changes
Jan 3, 2026
| observe([ | ||
| '.mergeability-details > *:last-child', // Old view - TODO: Drop after June 2025 | ||
| prMergeabilityBoxCaption, | ||
| prMergeabilityBoxHeader, |
Member
There was a problem hiding this comment.
Can't repro the original issue and sadly the element that this selector selects isn't even used by addButton.
Merging it but ideally we'd drop the legacy code soon and use observe correctly
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #8828.
The existing selector relied on specific text content (caption) within the merge box. This updates it to target the stable container class (
MergeBoxSectionHeader-module__wrapper), ensuring the button appears even if the text varies or is missing.