Skip to content

status-subscription - Restore feature#8790

Merged
fregante merged 15 commits intorefined-github:mainfrom
SunsetTechuila:status-subscription
Jan 10, 2026
Merged

status-subscription - Restore feature#8790
fregante merged 15 commits intorefined-github:mainfrom
SunsetTechuila:status-subscription

Conversation

@SunsetTechuila
Copy link
Member

@SunsetTechuila SunsetTechuila commented Nov 21, 2025

I don't really expect this to be merged

Fixes #7968

Test URLs

#8785

Screenshot

image

@SunsetTechuila
Copy link
Member Author

Is there is a way to obtain pr subscription state via api?

@fregante fregante added the bug label Nov 21, 2025
@fregante
Copy link
Member

Is there is a way to obtain pr subscription state via api?

No, that's the issue 🥲

}

const body = {
query: 'dd170c659a085a45885ee5a168fc52c8',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel that this is a generated ID and it might break on the next deployment. Let's wait a week or two.

Copy link
Member Author

@SunsetTechuila SunsetTechuila Nov 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel that this is a generated ID

Yes

Let's wait a week or two.

Absolutely

Copy link
Member Author

@SunsetTechuila SunsetTechuila Nov 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member Author

@SunsetTechuila SunsetTechuila Nov 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still works - the hash hasn't changed

Copy link
Member Author

@SunsetTechuila SunsetTechuila Dec 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The hash has changed, but the server doesn't reject requests with an outdated hash

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still works

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IssueViewerSecondaryViewQuery

Copy link
Member Author

@SunsetTechuila SunsetTechuila Jan 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Outdated hash still works

I think it's a good idea to keep track of how long the server will accept the outdated hash, so I will continue to leave comments like this from time to time. Please unsubscribe if you don't want to be notified

Copy link
Member Author

@SunsetTechuila SunsetTechuila Jan 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Outdated hash

The one currently used by the extension (fa182058c0b83a77481f98108cdbf1eb) is now outdated too - it has already changed again (86847801024939b9ae06cb1ca8a0c3dc)

const {id} = issue.repository.issue;

const body = {
query: 'd0752b2e49295017f67c84f21bfe41a3',
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This hash seems to be quite stable

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updateIssueSubscriptionMutation

@SunsetTechuila SunsetTechuila marked this pull request as ready for review January 4, 2026 07:40
@fregante
Copy link
Member

YOLO

@fregante fregante merged commit 19561e9 into refined-github:main Jan 10, 2026
8 checks passed
@fregante
Copy link
Member

Thanks for working on this! I didn't really expect this feature to ever work again. Let's hope we don't need to hotfix it

@fregante

This comment was marked as off-topic.

@SunsetTechuila SunsetTechuila deleted the status-subscription branch January 10, 2026 10:00
@fregante

This comment was marked as off-topic.

@SunsetTechuila

This comment was marked as off-topic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

status-subscription missing from new issue view

2 participants