Add cookies permissions missed in #8740#8786
Closed
prplecake wants to merge 1 commit intorefined-github:mainfrom
Closed
Add cookies permissions missed in #8740#8786prplecake wants to merge 1 commit intorefined-github:mainfrom
prplecake wants to merge 1 commit intorefined-github:mainfrom
Conversation
Member
|
Refer to #8782 (comment) Does this introduce new text in the permission dialog? If so, this change would make Firefox disable Refined GitHub updates everywhere. |
fregante
requested changes
Nov 21, 2025
Member
fregante
left a comment
fregante
left a comment
There was a problem hiding this comment.
From what I can tell it doesn't trigger a new permission dialog in neither Chrome nor Firefox, however:
- the permission requires an explanation in the web store, and it's not needed in Chrome, so it would be hard to justify
- we currently don't have any way to customize builds by browser, which impacts DX for local extension development
In the past we customized the build just before deployment, but it has drawbacks.
- if we leave
cookiesin the manifest.json and remove it in thechromedeployment: if this fails silently, a bad manifest will be published to the store - if we add
cookiesto the manifest.json in theFirefoxdeployment: developers won't be able to useopenTabslocally
Perhaps:
- add
cookiesto the manifest.json in theFirefoxdeployment - also check if the
cookiespermission exists before addingcookieStoreIdinopenTabs
For the time being I'll soft-revert the previous PR and release a new Refined GitHub version.
Member
|
Continues in #8657 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Really fixes #8657 this time. #8740 missed adding the required "cookies" permissions.
From https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/Work_with_contextual_identities#permissions:
Fixes #8785
Test URLs
Screenshot