Skip to content

more-file-links - Restore on new PR & commit pages #8757

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fregante merged 9 commits into from
Nov 12, 2025
Merged

more-file-links - Restore on new PR & commit pages #8757

Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
67f40ee
`more-file-links` - Restore on new PR & commit pages
SunsetTechuila Nov 10, 2025
c35d549
don't assign already assigned ariaKeyShortcuts
SunsetTechuila Nov 10, 2025
7712932
use `Versions` icon
SunsetTechuila Nov 10, 2025
d7efaed
apply suggestions
SunsetTechuila Nov 11, 2025
dc6b1c9
declare `getMenuItem` as function
SunsetTechuila Nov 11, 2025
f79e05a
remove trailing semicolon
SunsetTechuila Nov 11, 2025
9503b3f
select button by type
SunsetTechuila Nov 11, 2025
9c4c0ae
Merge remote-tracking branch 'origin/main' into pr/8757
fregante Nov 12, 2025
b437a9b
back to the future
fregante Nov 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
55 changes: 41 additions & 14 deletions source/features/more-file-links.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,34 +2,61 @@ import React from 'dom-chef';
import {$} from 'select-dom/strict.js';
import * as pageDetect from 'github-url-detection';
import delegate, {type DelegateEvent} from 'delegate-it';
import FileCodeIcon from 'octicons-plain-react/FileCode';
import VersionsIcon from 'octicons-plain-react/Versions';
import HistoryIcon from 'octicons-plain-react/History';

import features from '../feature-manager.js';
import GitHubFileURL from '../github-helpers/github-file-url.js';

function handleMenuOpening({delegateTarget: dropdown}: DelegateEvent): void {
function getLegacyMenuItem(viewFile: HTMLAnchorElement, name: string, route: string): JSX.Element {
const {href} = new GitHubFileURL(viewFile.href).assign({route});
return (
<a href={href} data-turbo={String(route !== 'raw')} className="pl-5 dropdown-item btn-link" role="menuitem">
View {name}
</a>
);
}

function handleLegacyMenuOpening({delegateTarget: dropdown}: DelegateEvent): void {
dropdown.classList.add('rgh-more-file-links'); // Mark this as processed

const viewFile = $('a[data-ga-click^="View file"]', dropdown);
const getDropdownLink = (name: string, route: string): JSX.Element => {
const {href} = new GitHubFileURL(viewFile.href).assign({route});
return (
<a href={href} data-turbo={String(route !== 'raw')} className="pl-5 dropdown-item btn-link" role="menuitem">
View {name}
</a>
);
};

viewFile.after(
getDropdownLink('raw', 'raw'),
getDropdownLink('blame', 'blame'),
getDropdownLink('history', 'commits'),
getLegacyMenuItem(viewFile, 'raw', 'raw'),
getLegacyMenuItem(viewFile, 'blame', 'blame'),
getLegacyMenuItem(viewFile, 'history', 'commits'),
<div className="dropdown-divider" role="none" />,
);
}

function getMenuItem(viewFile: HTMLElement, name: string, route: string, icon: React.JSX.Element): HTMLElement {
const menuItem = viewFile.cloneNode(true);
const fileLink = $('a', viewFile).href;
const link = $('a', menuItem);
link.href = new GitHubFileURL(fileLink).assign({route}).href;
link.dataset.turbo = String(route !== 'raw');
$('[class^="prc-ActionList-ItemLabel"]', menuItem).textContent = `View ${name}`;
$('[class^="prc-ActionList-LeadingVisual"]', menuItem).replaceChildren(icon);
return menuItem;
}

function handleMenuOpening(): void {
const viewFile = $('[class^="prc-ActionList-ActionListItem"]:has(.octicon-eye)');
viewFile.after(
getMenuItem(viewFile, 'raw', 'raw', <FileCodeIcon />),
getMenuItem(viewFile, 'blame', 'blame', <VersionsIcon />),
getMenuItem(viewFile, 'history', 'commits', <HistoryIcon />),
viewFile.nextElementSibling?.getAttribute('data-component') === 'ActionList.Divider'
? ''
: <li className="dropdown-divider" aria-hidden="true" data-component="ActionList.Divider" />,
);
}

function init(signal: AbortSignal): void {
// `capture: true` required to be fired before GitHub's handlers
delegate('.file-header .js-file-header-dropdown:not(.rgh-more-file-links)', 'toggle', handleMenuOpening, {capture: true, signal});
delegate('.file-header .js-file-header-dropdown:not(.rgh-more-file-links)', 'toggle', handleLegacyMenuOpening, {capture: true, signal});
delegate('[class^="DiffFileHeader-module__diff-file-header"] button:has(>.octicon-kebab-horizontal)', 'click', handleMenuOpening);
}

void features.add(import.meta.url, {
Expand Down