Skip to content

show-names - Avoid duplicates when unhiding comments #8756

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fregante merged 1 commit into from
Nov 11, 2025
Merged

show-names - Avoid duplicates when unhiding comments #8756

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 13 additions & 6 deletions source/features/show-names.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ import observe from '../helpers/selector-observer.js';
import {removeTextNodeContaining} from '../helpers/dom-utils.js';
import {usernameLinksSelector} from '../github-helpers/selectors.js';
import {expectToken} from '../github-helpers/github-token.js';
import attachElement from '../helpers/attach-element.js';

const emojiRegex = getEmojiRegex();

Expand All @@ -22,12 +23,9 @@ async function dropExtraCopy(link: HTMLAnchorElement): Promise<void> {
}
}

function appendName(element: HTMLAnchorElement, fullName: string): void {
// If it's a regular comment author, add it outside <strong> otherwise it's something like "User added some commits"
const {parentElement} = element;
const insertionPoint = parentElement!.tagName === 'STRONG' ? parentElement! : element;
function createElement(element: HTMLAnchorElement, fullName: string): JSX.Element {
const nameElement = (
<span className="color-fg-muted css-truncate d-inline-block">
<span className="color-fg-muted css-truncate d-inline-block rgh-show-names">
{/* .css-truncate-target sets display: inline-block and confines bidi overrides #8191 */}
(<span className="css-truncate-target" style={{maxWidth: '200px'}}>{fullName}</span>)
</span>
Expand All @@ -36,8 +34,17 @@ function appendName(element: HTMLAnchorElement, fullName: string): void {
const testId = element.getAttribute('data-testid');
if (testId && ['issue-body-header-author', 'avatar-link'].includes(testId))
nameElement.classList.add('ml-1');
return nameElement;
}

function appendName(element: HTMLAnchorElement, fullName: string): void {
// If it's a regular comment author, add it outside <strong> otherwise it's something like "User added some commits"
const {parentElement} = element;
const insertionPoint = parentElement!.tagName === 'STRONG' ? parentElement! : element;

insertionPoint.after(' ', nameElement, ' ');
// React might create a new label without removing the old one
// https://github.com/refined-github/refined-github/issues/8478
attachElement(insertionPoint, {after: () => createElement(element, fullName)});
}

async function updateLinks(found: HTMLAnchorElement[]): Promise<void> {
Expand Down