Skip to content

new-milestone-button - New feature#8699

Merged
fregante merged 2 commits intorefined-github:mainfrom
u01jmg3:main
Oct 12, 2025
Merged

new-milestone-button - New feature#8699
fregante merged 2 commits intorefined-github:mainfrom
u01jmg3:main

Conversation

@u01jmg3
Copy link
Contributor

@u01jmg3 u01jmg3 commented Oct 8, 2025

Copy link
Member

@fregante fregante left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

@u01jmg3
Copy link
Contributor Author

u01jmg3 commented Oct 8, 2025

I thought I had more time as this was a draft PR! 👅

Still got 1 failing test but not sure what I've missed

@u01jmg3 u01jmg3 marked this pull request as ready for review October 8, 2025 20:20
Copy link
Member

@fregante fregante left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Heheh I prefer giving early reviews so you don't spend time refining something that won't be accepted

Don't forget to run npm run fix to update the snapshots

@u01jmg3
Copy link
Contributor Author

u01jmg3 commented Oct 8, 2025

All changes made - npm run fix was causing issues because of NODE_NO_WARNINGS=1 in the vitest command, which I had to remove

@fregante fregante changed the title new-milestone-button - Add "New Milestone" button to milestone page (#8688) new-milestone-button - New feature Oct 9, 2025
@fregante
Copy link
Member

fregante commented Oct 9, 2025

All changes made - npm run fix was causing issues because of NODE_NO_WARNINGS=1 in the vitest command, which I had to remove

Oh that's because you're on Windows and ENVs are not set the same way

@u01jmg3
Copy link
Contributor Author

u01jmg3 commented Oct 9, 2025

Admittedly, I am 🪟

Was humming and heying on the code you removed - will be leaner next time

@bendiknesbo bendiknesbo mentioned this pull request Oct 10, 2025
@kidonng kidonng linked an issue Oct 10, 2025 that may be closed by this pull request
@fregante fregante merged commit c5b0ad0 into refined-github:main Oct 12, 2025
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

Missing "New Milestone" button when closing a milestone

2 participants