Rename more-dropdown to more-dropdown-links#4584
Merged
Conversation
fregante
approved these changes
Jul 19, 2021
Member
|
Unchecked but I assume it matches the previous code. Merge at will |
FloEdelmann
requested changes
Jul 19, 2021
readme.md
Outdated
| @@ -134,6 +134,7 @@ Thanks for contributing! 🦋🙌 | |||
| - [](# "hide-watch-and-fork-count") [Hides watcher counter and on smaller screens the fork counter too.](https://user-images.githubusercontent.com/1402241/53681077-f3328b80-3d1e-11e9-9e29-2cb017141769.png) | |||
| - [](# "sort-milestones-by-closest-due-date") Changes the default sort order of milestones `Closest due date`. | |||
| - [](# "more-dropdown") [Adds useful links to the repository navigation dropdown and moves the "Security" and "Insights" tabs to it as well.](https://user-images.githubusercontent.com/16872793/124681432-856e6f80-de96-11eb-89c9-6d78e8ae4329.png) | |||
Member
There was a problem hiding this comment.
This line should be dropped, right?
| } | ||
|
|
||
| async function init(): Promise<void> { | ||
| // The user may have disabled `more-dropdown` so un-hide it |
Member
There was a problem hiding this comment.
Suggested change
| // The user may have disabled `more-dropdown` so un-hide it | |
| // The user may have disabled `more-dropdown-links` so un-hide it |
This comment has been minimized.
This comment has been minimized.
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migration will happen in #4568, after the feature is renamed.