Skip to content

Make tall code blocks scrollable #1146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fregante merged 19 commits into from
Mar 8, 2019
Merged

Make tall code blocks scrollable #1146

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
5c6f441
Added max-height to blockquote and pre
rooneyg21 Mar 8, 2018
b51c6c1
merged blockquote and pre selectors
rooneyg21 Mar 27, 2018
af44a9f
Added a bottom shadow when there is an overflow
rooneyg21 Mar 27, 2018
b6f25fb
limit the scrollbar to comments
rooneyg21 Mar 27, 2018
f4f0ac9
removed duplicate props
rooneyg21 Mar 29, 2018
fc5eb39
removed legacy browser support
rooneyg21 Mar 29, 2018
9ba4199
Apply in more situations
fregante Mar 29, 2018
a9e33e8
Make shadow less conspicuous
fregante Mar 29, 2018
840387c
Stylelint annoyance ❗️
fregante Mar 29, 2018
45d1232
Use correct cover color in pre elements
fregante Mar 29, 2018
7017230
Don't create nested scrolling areas
fregante Mar 29, 2018
c68dc9f
If in a <details>, don't collapse
fregante Apr 19, 2018
ba05fc6
Merge branch 'master' into bug-tall-code-scroll-1123
fregante Apr 20, 2018
b42737f
Restore pre background (recent GH code changes?)
fregante Apr 20, 2018
5209be4
Typo
fregante May 19, 2018
d5efa49
Merge branch 'master' into bug-tall-code-scroll-1123
fregante Feb 16, 2019
97ed9f6
Drop shadows
fregante Feb 16, 2019
49567b8
Update readme.md
fregante Mar 8, 2019
2f0909d
Merge branch 'master' into bug-tall-code-scroll-1123
fregante Mar 8, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions readme.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,6 +151,7 @@ GitHub Enterprise is also supported. More info in the options.
- [The autocomplete on the issue search field is removed.](https://user-images.githubusercontent.com/1402241/42991841-1f057e4e-8c07-11e8-909c-b051db7a2a03.png)
- [Forks are hidden from a user's Repositories list (but they can still be shown)](https://user-images.githubusercontent.com/1402241/45133648-fe21be80-b1c8-11e8-9052-e38cb443efa9.png)
- [Reaction comments ("+1", "👍", …) are hidden](https://user-images.githubusercontent.com/1402241/45543717-d45f3c00-b847-11e8-84a5-8c439d0ad1a5.png) (except the maintainers') [but they can still be shown.](https://user-images.githubusercontent.com/1402241/45543720-d628ff80-b847-11e8-9fb6-758a3102e3a9.png)
- [Tall code blocks and quotes are limited in height.](https://github.com/sindresorhus/refined-github/issues/1123)
- [Forks and watchers counters are hidden.](https://user-images.githubusercontent.com/1402241/53681077-f3328b80-3d1e-11e9-9e29-2cb017141769.png)

### UI improvements
Expand Down
14 changes: 14 additions & 0 deletions source/content.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -953,6 +953,20 @@ body > .footer li a {
cursor: pointer;
}

.comment-body blockquote,
.comment-body pre {
position: relative; /* OctoLinker compat: attach the purple balls to the scroll */
max-height: 30.5em;
overflow-y: auto;
}

.comment-body details blockquote,
.comment-body details pre,
.comment-body blockquote blockquote,
.comment-body blockquote pre {
max-height: none;
}

/* For 'add-jump-to-bottom-link' feature */
#rgh-jump-to-bottom-link {
display: inline-block; /* Avoid breaking link in two lines */
Expand Down