Implement redis connection broken mode#829
Merged
Merged
Conversation
Contributor
Author
|
This branch is going to fix a lot of issues for quite some people. |
Contributor
Author
Contributor
Author
There was a problem hiding this comment.
This is a preparation for the multi fixes.
Contributor
Author
|
This is going to do the following:
|
Contributor
Author
|
This should be ready to merge |
Earlier the first value was never used, as it was first multiplied by 1.7
…een exceeded Accept setting max_attempts to zero. The reconnection event is now emitted when trying to reconnect instead of earlier. The connection timeout is now going to trigger once after exceeding the maximum timeout instead of stopping earlier.
…works, the others are going to be fine too)
Use a new delay after reconnecting
Add more tests
This was referenced Sep 16, 2015
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is also going to change some small things like adding a maximum timeout.