Feature: Emit an event when the maximum number of connection attempts has been reached#724
Closed
hrdwdmrbl wants to merge 1 commit into
Closed
Feature: Emit an event when the maximum number of connection attempts has been reached#724hrdwdmrbl wants to merge 1 commit into
hrdwdmrbl wants to merge 1 commit into
Conversation
… has been reached
|
+1 |
1 similar comment
Contributor
|
+1 |
Contributor
|
Duplicate of #615 @jackquack if you're up to fix the comments of 615 before @tobek does (the PR is quite old already) and add some tests, I'll merge this. |
BridgeAR
pushed a commit
that referenced
this pull request
Sep 11, 2015
BridgeAR
pushed a commit
that referenced
this pull request
Sep 11, 2015
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I followed the lead of the TODO comment, though I think my preferred solution would be that an error event is raised, similar to when a connection cannot be established in the first place, or when the redis server disappears completely.
Anyway, we wanted this for our own purposes, and it was easy to add. :)