Enough reconnection retry before flushing out offline queue#362
Closed
vedratna-velani wants to merge 1 commit into
Closed
Enough reconnection retry before flushing out offline queue#362vedratna-velani wants to merge 1 commit into
vedratna-velani wants to merge 1 commit into
Conversation
Contributor
|
I've also hit this myself -- #280 so I agree this is important. We may want to consider a couple things though: 1: Is there a reasonable default value we could set for this new option? |
Contributor
There was a problem hiding this comment.
checking that it is greater than zero should be enough? Or just set it to -1 as the default value.
Contributor
|
Thx a lot for your work but closing this in favor of #829. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I came across the scenario where under heavy traffic or due to some connection issue, got redis connection error and redis command just fails with error. Instead I think it should have an option to retry enough before error out the command.