[vector sets] address review comments

ggivo · ggivo · commit b9ad53eb488d · 2025-08-27T10:49:20.000+03:00
- remove unused import
  - remove unused helper methods
diff --git a/src/main/java/redis/clients/jedis/BuilderFactory.java b/src/main/java/redis/clients/jedis/BuilderFactory.java
@@ -2,7 +2,6 @@
 
 import java.io.Serializable;
 import java.util.*;
-import java.util.function.Function;
 import java.util.stream.Collectors;
 
 import redis.clients.jedis.exceptions.JedisDataException;
diff --git a/src/main/java/redis/clients/jedis/commands/VectorSetBinaryCommands.java b/src/main/java/redis/clients/jedis/commands/VectorSetBinaryCommands.java
@@ -345,5 +345,4 @@ Map<byte[], VSimScoreAttribs> vsimByElementWithScoresAndAttribs(byte[] key, byte
    */
   @Experimental
   boolean vsetattr(byte[] key, byte[] element, byte[] attributes);
-
 }
diff --git a/src/test/java/redis/clients/jedis/commands/unified/VectorSetCommandsTestBase.java b/src/test/java/redis/clients/jedis/commands/unified/VectorSetCommandsTestBase.java
@@ -1718,37 +1718,4 @@ private void setupVSimTestSetBinaryWithAttribs(byte[] testKey) {
     jedis.vadd(testKey, vector3, "element3".getBytes());
   }
 
-  /**
-   * Helper method to set up test vector set for binary VSIM by element tests with attributes.
-   */
-  private void setupVSimByElementTestSetBinaryWithAttribs(byte[] testKey) {
-    // Add test vectors with attributes for element-based similarity
-    float[] vector1 = { 0.1f, 0.2f, 0.3f };
-    float[] vector2 = { 0.12f, 0.22f, 0.32f };
-    float[] vector3 = { 0.9f, 0.8f, 0.7f };
-
-    VAddParams addParams1 = new VAddParams().setAttr("type=reference,quality=high");
-    jedis.vadd(testKey, vector1, "reference".getBytes(), addParams1);
-
-    VAddParams addParams2 = new VAddParams().setAttr("type=similar,quality=medium");
-    jedis.vadd(testKey, vector2, "similar1".getBytes(), addParams2);
-
-    VAddParams addParams3 = new VAddParams().setAttr("type=different,quality=low");
-    jedis.vadd(testKey, vector3, "different".getBytes(), addParams3);
-  }
-
-  /**
-   * Helper method to get VSimScoreAttribs for a specific element from binary score map.
-   */
-  private VSimScoreAttribs getBinaryScoreAttribsForElement(Map<byte[], VSimScoreAttribs> scoreMap,
-      String elementName) {
-    byte[] elementBytes = elementName.getBytes();
-    for (Map.Entry<byte[], VSimScoreAttribs> entry : scoreMap.entrySet()) {
-      if (java.util.Arrays.equals(entry.getKey(), elementBytes)) {
-        return entry.getValue();
-      }
-    }
-    return null;
-  }
-
 }

Original file line number	Diff line number	Diff line change
`@@ -345,5 +345,4 @@ Map<byte[], VSimScoreAttribs> vsimByElementWithScoresAndAttribs(byte[] key, byte`
`345`	`345`	`*/`
`346`	`346`	`@Experimental`
`347`	`347`	`boolean vsetattr(byte[] key, byte[] element, byte[] attributes);`
`348`		`-`
`349`	`348`	`}`