Skip to content

Remove all DNS and resolver client manipulations from heat stack#324

Merged
tomassedovic merged 1 commit into
redhat-openstack:masterfrom
markllama:rip-dns
Mar 8, 2017
Merged

Remove all DNS and resolver client manipulations from heat stack#324
tomassedovic merged 1 commit into
redhat-openstack:masterfrom
markllama:rip-dns

Conversation

@markllama

Copy link
Copy Markdown
Contributor

This PR removes all code used to manipulate the DNS and resolver configuration of the instances prior to the execution of the openshift-ansible playbooks.

The cloud provider must offer correct host naming, and name resolution configuration as presented to the stack through the OS::Neutron::Network and Subnet object configurations and through the cloud-init inputs.

@markllama markllama changed the title Remove all DNS and resolver client manipulations from heat stack [no-merge] Remove all DNS and resolver client manipulations from heat stack Mar 2, 2017
@tomassedovic

Copy link
Copy Markdown
Contributor

This looks solid, thanks! I've noticed that the *-boot.sh scripts still mention SKIP_DNS in the top section:

https://github.com/markllama/openshift-on-openstack/blob/3bfc87481a29ee642c73507c7d02aceb682341c7/fragments/infra-boot.sh#L6

Also, shouldn't we remove the default setting for dns_nameserver now? This needs to point to a DNS server under the deployer's control so there's no suitable default now.

@markllama markllama changed the title [no-merge] Remove all DNS and resolver client manipulations from heat stack Remove all DNS and resolver client manipulations from heat stack Mar 8, 2017
@tomassedovic tomassedovic merged commit fb981f5 into redhat-openstack:master Mar 8, 2017
@markllama markllama deleted the rip-dns branch March 16, 2017 16:42
@ganhuang

Copy link
Copy Markdown

@markllama @tomassedovic Could you guys explain or document more for the current deployment due to the changes. Now the heat stack would ultimately fail due to the internal hostnames of the instances can't be resloved. I suspect we still need update_etc_hosts() to add internal dns mappings for all instances at least. Appreciate for any help.

@ganhuang ganhuang mentioned this pull request Mar 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants