Remove all DNS and resolver client manipulations from heat stack#324
Merged
Conversation
Contributor
|
This looks solid, thanks! I've noticed that the Also, shouldn't we remove the default setting for |
This was referenced Mar 17, 2017
|
@markllama @tomassedovic Could you guys explain or document more for the current deployment due to the changes. Now the heat stack would ultimately fail due to the internal hostnames of the instances can't be resloved. I suspect we still need |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes all code used to manipulate the DNS and resolver configuration of the instances prior to the execution of the openshift-ansible playbooks.
The cloud provider must offer correct host naming, and name resolution configuration as presented to the stack through the OS::Neutron::Network and Subnet object configurations and through the cloud-init inputs.