feat(snippet): making the library synchronous again#855
Merged
Conversation
erunion
added
enhancement
kanadgupta
approved these changes
Apr 9, 2024
Contributor
kanadgupta
left a comment
kanadgupta
left a comment
There was a problem hiding this comment.
tysm for this 👑 before you tag a new release let me know, i might try and spend a little time tomorrow morning tightening up a few types
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🧰 Changes
@kanadgupta has been running into some trouble this week trying to upgrade our
oas-to-snippetintegration in our API Explorer to comply with its new asynchronous nature. Instead of trying to refactor the internals of formdata-to-string, which is requiring httpsnippet to be async, I ended up figuring out a way to removeformdata-to-stringentirely.readmeio/httpsnippet#224
With that work
oas-to-snippetcan be a synchronous library again.This will be a breaking change to
oas-to-snippet.