Skip to content

wip: attempt to fix constraint solving infinite loop #2012

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
j-g00da wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

wip: attempt to fix constraint solving infinite loop #2012

j-g00da wants to merge 1 commit into from

Conversation

@j-g00da
Copy link
Member

@j-g00da j-g00da commented Jul 22, 2025 •
edited
Loading

[DO NOT MERGE]

Related: #1855

@github-actions
Copy link
Contributor

github-actions bot commented Jul 22, 2025

Thank you for opening this pull request!

We require pull request titles to follow the Conventional Commits specification and it looks like your proposed title needs to be adjusted.

Details:

Unknown release type "wip" found in pull request title "wip: attempt to fix constraint solving infinite loop".

Available types:

  • feat: A new feature
  • fix: A bug fix
  • docs: Documentation only changes
  • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
  • refactor: A code change that neither fixes a bug nor adds a feature
  • perf: A code change that improves performance
  • test: Adding missing tests or correcting existing tests
  • build: Changes that affect the build system or external dependencies (example scopes: gulp, broccoli, npm)
  • ci: Changes to our CI configuration files and scripts (example scopes: Travis, Circle, BrowserStack, SauceLabs)
  • chore: Other changes that don't modify src or test files
  • revert: Reverts a previous commit

@j-g00da
Copy link
Member Author

j-g00da commented Jul 22, 2025

Draft fix in kasuari: ratatui/kasuari#24

@j-g00da j-g00da force-pushed the js/fix-layout-infinite-loop branch from c5d8ad5 to e602369 Compare July 22, 2025 22:25
Teufelchen1
Teufelchen1 reviewed Jul 23, 2025
View reviewed changes
ratatui-core/src/layout/layout.rs
Comment on lines +2838 to +2842
#[rstest]
#[timeout(core::time::Duration::from_secs(10))]
fn regression_1855() {
Layout::horizontal(vec![Min(0); 40]).split(Rect::new(0, 0, 40, 1));
}
Copy link

@Teufelchen1 Teufelchen1 Jul 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ohh 💡! This is much smarter than my loop-count-abort test. Thanks for developing in the open.

@a-kenji
Copy link
Contributor

a-kenji commented Jul 23, 2025 •
edited
Loading

At the risk of spamming this PR, apologies in advance.
I feel the gh-actions bot should maybe not run on Draft PR's.

Edit: Ah, WIP is already an accepted prefix.

@joshka
Copy link
Member

joshka commented Jul 23, 2025

We don't worry too much about bot messages (this and code cov problems). They're there to remind us to fix up stuff before merging. Feel free to ignore it until then.

@j-g00da j-g00da added this to the v0.31.0 milestone Oct 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@Teufelchen1 Teufelchen1 Teufelchen1 left review comments

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

v0.31.0

Development

Successfully merging this pull request may close these issues.

5 participants

@j-g00da @a-kenji @joshka @Teufelchen1