Clean contentView_ reference in onDestroyView()

Nikolay Belikov · Nikolay Belikov · commit c1c6a60c51a4 · 2014-09-29T20:20:57.000+04:00
If setRetainInstance(true) has been set on the fragment or
addToBackStack() was applied to FragmentTransaction, the fragment won't be
destroyed and will keep the reference to its parent view in contentView_
and could lead to memory leak.

This change implements onDestroyView() which cleans the reference.
However, the developer is still responsible for cleaning up the injected
views, because otherwise a (badly implemented) background task may get a
NullPointerException.
diff --git a/AndroidAnnotations/androidannotations/src/main/java/org/androidannotations/holder/EFragmentHolder.java b/AndroidAnnotations/androidannotations/src/main/java/org/androidannotations/holder/EFragmentHolder.java
@@ -219,6 +219,7 @@ public JFieldVar getContentView() {
 		if (contentView == null) {
 			setContentView();
 			setOnCreateView();
+			setOnDestroyView();
 		}
 		return contentView;
 	}
@@ -244,6 +245,14 @@ private void setOnCreateView() {
 		body._return(contentView);
 	}
 
+	private void setOnDestroyView() {
+		JMethod onDestroyView = generatedClass.method(PUBLIC, codeModel().VOID, "onDestroyView");
+		onDestroyView.annotate(Override.class);
+		JBlock body = onDestroyView.body();
+		body.assign(contentView, _null());
+		body.invoke(_super(), onDestroyView);
+	}
+
 	private void setOnStart() {
 		JMethod onStart = generatedClass.method(PUBLIC, codeModel().VOID, "onStart");
 		onStart.annotate(Override.class);
