Skip to content

Conversation

@ulope
Copy link
Collaborator

@ulope ulope commented May 19, 2021

Description

Fixes: #

Please, describe what this PR does in detail:

  • If it's a bug fix, detail the root cause of the bug and how this PR fixes it.
  • If it's a new feature, describe the feature this PR is introducing and design decisions.
  • If it's a refactoring, describe why it is necessary. What are its pros and cons in respect to the previous code, and other possible design choices.

ulope added 2 commits May 19, 2021 19:29
Our bundled binaries seem to have been not working for some time.

We had two separate issues:
- The `av` dependency (via `aiortc`) wasn't being properly discovered
  by PyInstaller.
  This has been fixed with a hook.
- On Linux stripping of the libraries apparently causes some corruption
  See: pypa/manylinux#119
  Therefore stripping is disabled for now.
- The gevent runtime hook would attempt to start the aio event loop. 
  This caused a warning about an already running loop.

This also fixes:
- Don't include unnecessary av libraries in the bundle
- Remove no longer used GETH_URL and SOLC_URL build args from the
  `bundle-docker` make target.
- On CI: Invoke the built binaries with `--help` as a minimal
  functionality sanity check.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant