-
Notifications
You must be signed in to change notification settings - Fork 91
fix(deps): update dependency vega to v6 [security] #4643
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #4643 +/- ##
===========================================
+ Coverage 43.22% 93.32% +50.09%
===========================================
Files 797 117 -680
Lines 32003 10305 -21698
Branches 5699 0 -5699
===========================================
- Hits 13833 9617 -4216
+ Misses 16176 688 -15488
+ Partials 1994 0 -1994
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1 file reviewed, no comments
5ab2eec to
4ac4b13
Compare
9a7a88d to
2b7fe43
Compare
a1eea51 to
3a0f97f
Compare
6d0f34e to
7f3cd14
Compare
df05d8c to
5797da0
Compare
5797da0 to
3c91161
Compare
This PR contains the following updates:
^5.33.0→^6.0.0GitHub Vulnerability Alerts
CVE-2025-59840
Impact
Applications meeting 2 conditions are at risk of arbitrary JavaScript code execution, even if "safe mode" expressionInterpreter is used.
vegain an application that attachesvegalibrary and avega.Viewinstance similar to the Vega Editor to the globalwindowJSONdefinitions (vs JSON that was is only provided through source code)Patches
vega6.2.0/vega-expression6.1.0/vega-interpreter2.2.1(if using AST evaluator mode)vega-expression5.2.1/1.2.1(if using AST evaluator mode)Workarounds
Is there a way for users to fix or remediate the vulnerability without upgrading
vegaView instances to global variables, as Vega editor used to do herevegato the global window as the editor used to do hereThese practices of attaching the vega library and View instances may be convenient for debugging, but should not be used in production or in any situation where vega/vega-lite definitions could be provided by untrusted parties.
POC Summary
Vega offers the evaluation of expressions in a secure context. Arbitrary function call is prohibited. When an event is exposed to an expression, member get of window objects is possible. Because of this exposure, in some applications, a crafted object that overrides its toString method with a function that results in calling
this.foo(this.bar), DOM XSS can be achieved.In practice, an accessible gadget like this exists in the global VEGA_DEBUG code.
POC Details
{ "$schema": "https://vega.github.io/schema/vega/v5.json", "width": 350, "height": 350, "autosize": "none", "description": "Toggle Button", "signals": [ { "name": "toggle", "value": true, "on": [ { "events": {"type": "click", "markname": "circle"}, "update": "toggle ? false : true" } ] }, { "name": "addFilter", "on": [ { "events": {"type": "mousemove", "source": "window"}, "update": "({toString:event.view.VEGA_DEBUG.vega.CanvasHandler.prototype.on, eventName:event.view.console.log,_handlers:{undefined:'alert(origin + ` XSS on version `+ VEGA_DEBUG.VEGA_VERSION)'},_handlerIndex:event.view.eval})+1" } ] } ] }This payload creates a scenario where whenever the mouse is moved, the toString function of the provided object is implicitly called when trying to resolve adding it with 1. The toString function has been overridden to a "gadget function" (VEGA_DEBUG.vega.CanvasHandler.prototype.on) that does the following:
uto the result of callingthis.eventNamewith undefineddtothis._handlersthis._handlerIndexwith the result ofuindexed into thedobject as the first argument, and undefined as the second two._handlerIndexis set to window.eval, and when indexing undefined into the_handlers, a string to be evald containing the XSS payload is returned.This results in XSS by using a globally scoped gadget to get full blown eval.
PoC Link
Navigate to vega editor, move the mouse, and observe that the arbitrary JavaScript from the configuration reaches the eval sink and DOM XSS is achieved.
Future investigation
In cases where
VEGA_DEBUGis not enabled, there theoreticallycould be other gadgets on the global scope that allow for similar behavior. In cases where AST evaluator is used and there are blocks against getting references toeval, in theory there could be other gadgets on global scope (i.e. jQuery) that would allow for eval the same way (i.e.$.globalEval). As of this writing, no such globally scoped gadgets have been found.Impact
This vulnerability allows for DOM XSS, potentially stored, potentially reflected, depending on how the library is being used. The vulnerability requires user interaction with the page to trigger.
An attacker can exploit this issue by tricking a user into opening a malicious Vega specification. Successful exploitation allows the attacker to execute arbitrary JavaScript in the context of the application’s domain. This can lead to theft of sensitive information such as authentication tokens, manipulation of data displayed to the user, or execution of unauthorized actions on behalf of the victim. This exploit compromises confidentiality and integrity of impacted applications.
Release Notes
vega/vega (vega)
v6.2.0Compare Source
v6.1.2Compare Source
v6.1.1Compare Source
v6.1.0Compare Source
v6.0.0Compare Source
changes since v5.33.0
monorepo
vega-typings
docs
Configuration
📅 Schedule: Branch creation - "" (UTC), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.