Skip to content

Comments

Feature/named arg support#953

Merged
filmor merged 6 commits intopythonnet:masterfrom
s4v4g3:feature/namedArgSupport
Sep 12, 2019
Merged

Feature/named arg support#953
filmor merged 6 commits intopythonnet:masterfrom
s4v4g3:feature/namedArgSupport

Conversation

@s4v4g3
Copy link
Contributor

@s4v4g3 s4v4g3 commented Sep 10, 2019 •
edited
Loading

What does this implement/fix? Explain your changes.

Adds support for kwarg/named arguments when calling .NET methods from python
...

Does this close any currently open issues?

Yes, #849
...

Any other comments?

...

Checklist

Check all those that are applicable and complete.

  • Make sure to include one or more tests for your change
  • If an enhancement PR, please create docs and at best an example
  • Add yourself to AUTHORS
  • Updated the CHANGELOG

filmor
filmor requested changes Sep 11, 2019
View reviewed changes
Copy link
Member

@filmor filmor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very very much for this addition, this was a quite long-standing issue. The only thing missing is handling for optional non-default parameters that are allowed in both C# and F#.

@s4v4g3 s4v4g3 requested a review from filmor September 12, 2019 00:42
@codecov-io
Copy link

codecov-io commented Sep 12, 2019 •
edited
Loading

Codecov Report

Merging #953 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #953   +/-   ##
=======================================
  Coverage   86.71%   86.71%           
=======================================
  Files           1        1           
  Lines         301      301           
=======================================
  Hits          261      261           
  Misses         40       40
Flag Coverage Δ
#setup_linux 65.44% <ø> (ø) ⬆️
#setup_windows 71.42% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f1da55e...d56e9a7. Read the comment docs.

@filmor
Copy link
Member

filmor commented Sep 12, 2019

Great, thanks :)

I'm not sure whether this DLL runs completely on .NET 4.0 anyway, we're going to require at least 4.7.2 in the future for .NET Standard compatibility. Since you left a comment on the respective line, we can shorten this later, though, so that's completely fine.

@filmor filmor merged commit 1bcbeb5 into pythonnet:master Sep 12, 2019
AlexCatarino pushed a commit to QuantConnect/pythonnet that referenced this pull request Dec 19, 2019
@s4v4g3 @AlexCatarino
Feature/named arg support (pythonnet#953)
677d980 
* Add support for named arguments (pythonnet#849)
* Remove kwarg check since it breaks the python-derived CLR class use-case
* Add named parameter test cases
* Update changelog and authors
* Add default params tests
AlexCatarino pushed a commit to QuantConnect/pythonnet that referenced this pull request Jun 18, 2020
@s4v4g3 @AlexCatarino
Feature/named arg support (pythonnet#953)
17bc3f5 
* Add support for named arguments (pythonnet#849)
* Remove kwarg check since it breaks the python-derived CLR class use-case
* Add named parameter test cases
* Update changelog and authors
* Add default params tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@filmor filmor filmor approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@s4v4g3 @codecov-io @filmor @joesavage-silabs