Minimal Py_IntializeEx change#777
Merged
filmor merged 3 commits intopythonnet:masterfrom Nov 15, 2018
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #777 +/- ##
==========================================
- Coverage 77.04% 63.6% -13.45%
==========================================
Files 63 1 -62
Lines 5786 283 -5503
Branches 911 0 -911
==========================================
- Hits 4458 180 -4278
+ Misses 1024 103 -921
+ Partials 304 0 -304
Continue to review full report at Codecov.
|
filmor
force-pushed
the
minimal-initializeex
branch
from
43c56bb to
62634f9
Compare
Contributor
|
@filmor why did you switch both x86 & x64 to AnyCPU? |
Member
Author
|
Argh, sorry, I wanted to exclude this part from the branch :/ I'll revert that particular change. |
Contributor
|
@filmor py27 got stuck in appveyor for master branch. I restarted the build. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this implement/fix? Explain your changes.
Minimal version of #724, allows the user to select whether an embedded Python should configure signal handlers or not, defaulting to "false" (which is different from what we had before as a straight call to
Py_Initializewill configure signal handlers).Does this close any currently open issues?
Fixes #449.
Any other comments?
We should follow up on #724 to get a unit test working for this, but this can wait until after 2.4.0.