Params arg no params#1106
Merged
filmor merged 12 commits intopythonnet:masterfrom May 16, 2020
slide:params_arg_no_params
Merged
Params arg no params#1106filmor merged 12 commits intopythonnet:masterfrom slide:params_arg_no_params
filmor merged 12 commits intopythonnet:masterfrom
slide:params_arg_no_params
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1106 +/- ##
=======================================
Coverage 86.75% 86.75%
=======================================
Files 1 1
Lines 302 302
=======================================
Hits 262 262
Misses 40 40
Continue to review full report at Codecov.
|
lostmsu
requested changes
Apr 9, 2020
Contributor
Author
|
Close and reopen to see if the build is intermittent. |
lostmsu
reviewed
Apr 9, 2020
lostmsu
approved these changes
Apr 9, 2020
Contributor
Author
|
Thanks for reopening, got pulled into a meeting and didn't get a chance to reopen. |
Member
|
@slide better this one. Then I can squash. |
lostmsu
approved these changes
Apr 9, 2020
Member
|
@slide Travis passed. Need to investigate why is it not being picked up. |
|
|
Contributor
Author
|
Close and reopen to try and get a Travis build responding. |
Member
|
Thank you very much :) |
AlexCatarino
pushed a commit
to QuantConnect/pythonnet
that referenced
this pull request
Jun 29, 2020
Add a check to see if the last parameter is a params parameter. Set the correct flag to show that it is a paramsArray function. Fixes pythonnet#943 and pythonnet#331.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this implement/fix? Explain your changes.
Check the last parameter to see if it is params (and not supplied). By setting the
paramsArrayvariable, the binding code does the right thing and passes an empty array.Does this close any currently open issues?
#943
Checklist
Check all those that are applicable and complete.
AUTHORSCHANGELOG