Removed unused imports#239
Merged
vasily-v-ryabov merged 6 commits intopython-xlib:masterfrom Dec 25, 2022
Merged
Conversation
Avasam
force-pushed
the
unused-imports
branch
from
aa3e1b1 to
fb64c64
Compare
Avasam
commented
Nov 16, 2022
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #239 +/- ##
==========================================
- Coverage 78.25% 78.23% -0.03%
==========================================
Files 42 42
Lines 4710 4704 -6
==========================================
- Hits 3686 3680 -6
Misses 1024 1024 |
Avasam
commented
Nov 16, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found a handful of unused imports.
The dependency on tkinter was also unnecessary as it was only importing a single constant (which is not even used by Xlib).
I kept the constant so this doesn't count as a breaking change (idk if it's meant to be part of the protocol).Fixes #240