[fix bug]-cannot use a str to initialize an array with typecode 'B'#187
Open
jinxiangwzh wants to merge 1 commit intopython-xlib:masterfrom
Open
[fix bug]-cannot use a str to initialize an array with typecode 'B'#187jinxiangwzh wants to merge 1 commit intopython-xlib:masterfrom
jinxiangwzh wants to merge 1 commit intopython-xlib:masterfrom
Conversation
Contributor
|
Thank you for the PR, but this change breaks a lot of unit tests (see the CI build failure), so can you look at that and see what you need change in the code to ensure they still work, please? I'm also not sure what the bug is here. Could you explain to which methods or requests you want to pass in a string to this structure, rather than controlling the encoding of it to an array yourself? I'm thinking that such encoding could make more sense in the wrapping methods in the X objects (Display, Window etc), rather than this low down in the protocol implementation. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.