Claim ownership of socket once we've passed it to libldap#544
Merged
mistotebe merged 1 commit intopython-ldap:mainfrom Nov 2, 2023
Merged
Claim ownership of socket once we've passed it to libldap#544mistotebe merged 1 commit intopython-ldap:mainfrom
mistotebe merged 1 commit intopython-ldap:mainfrom
Conversation
tiran
reviewed
Nov 2, 2023
mistotebe
force-pushed
the
socket-ownership
branch
from
b51740e to
d7b80de
Compare
tiran
approved these changes
Nov 2, 2023
Member
tiran
left a comment
tiran
left a comment
There was a problem hiding this comment.
Excellent work, thanks for digging into this rabbit hole.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per Python docs a
socketobject will close the underlying file descriptor on garbage collection and to use it elsewhere, one needs to calldetach().Fixes: #460
Closes: #543