Skip to content

Comments

bpo-19569: Add a macro to suppress deprecation warnings (counterpart of Py_DEPRECATED())#9004

Merged
methane merged 3 commits intopython:masterfrom
ZackerySpytz:bpo-19569-macro-depr-suppress
Jun 16, 2020
Merged

bpo-19569: Add a macro to suppress deprecation warnings (counterpart of Py_DEPRECATED())#9004
methane merged 3 commits intopython:masterfrom
ZackerySpytz:bpo-19569-macro-depr-suppress

Conversation

@ZackerySpytz
Copy link
Contributor

@ZackerySpytz ZackerySpytz commented Aug 29, 2018 •
edited by bedevere-bot
Loading

Co-Authored-By: Arfrever Frehtes Taifersar Arahesis [email protected]

https://bugs.python.org/issue19569

@ZackerySpytz @Arfrever
bpo-19569: Add a macro to suppress deprecation warnings (counterpart …
b57ceb2 
…of Py_DEPRECATED())

Co-Authored-By: Arfrever Frehtes Taifersar Arahesis <[email protected]>
jdemeyer
jdemeyer reviewed Aug 5, 2019
View reviewed changes
Copy link
Contributor

@jdemeyer jdemeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you should explain more clearly why this is needed.

@ZackerySpytz
Copy link
Contributor Author

ZackerySpytz commented Aug 8, 2019

These macros can be used to locally suppress deprecation warnings if a deprecated C API function needs to be used. There was some relevant discussion on the BPO issue.

@jdemeyer
Copy link
Contributor

jdemeyer commented Aug 9, 2019

There was some relevant discussion on the BPO issue.

Could you give a more concrete pointers? I didn't find the justification for this PR.

@methane
Copy link
Member

methane commented Jun 15, 2020

Could you give a more concrete pointers? I didn't find the justification for this PR.

When I uncomment Py_DEPRECATED macros in Include/cpython/unicodeobject.h,
I see some warning in _testcapimodule.c.

@methane methane mentioned this pull request Jun 15, 2020
Merged
@methane
Copy link
Member

methane commented Jun 15, 2020

It seems these macros are too much.
I just want a Py_SUPRESS_DEPRECATED_DECLS macro.

@methane
Copy link
Member

methane commented Jun 15, 2020

@ZackerySpytz Would you make these macros private? (e.g. adding _ prefix).
I want to use it in Python 3.9, but I don't want to add public API to 3.9.

@methane methane merged commit de4304d into python:master Jun 16, 2020
@miss-islington
Copy link
Contributor

miss-islington commented Jun 16, 2020

Thanks @ZackerySpytz for the PR, and @methane for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9.
🐍🍒⛏🤖

@bedevere-bot
Copy link

bedevere-bot commented Jun 16, 2020

GH-20907 is a backport of this pull request to the 3.9 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 16, 2020
@ZackerySpytz @miss-islington
bpo-19569: Add a macro to suppress deprecation warnings (pythonGH-9004)
ffca914 
Co-authored-by: Arfrever Frehtes Taifersar Arahesis <[email protected]>
(cherry picked from commit de4304d)

Co-authored-by: Zackery Spytz <[email protected]>
miss-islington added a commit that referenced this pull request Jun 17, 2020
@miss-islington @ZackerySpytz
bpo-19569: Add a macro to suppress deprecation warnings (GH-9004)
2c6d6c1 
Co-authored-by: Arfrever Frehtes Taifersar Arahesis <[email protected]>
(cherry picked from commit de4304d)

Co-authored-by: Zackery Spytz <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jdemeyer jdemeyer jdemeyer left review comments

@serhiy-storchaka serhiy-storchaka Awaiting requested review from serhiy-storchaka

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@ZackerySpytz @jdemeyer @methane @miss-islington @bedevere-bot @the-knights-who-say-ni