Skip to content

bpo-46469: Make asyncio generic classes return GenericAlias#30777

Merged
asvetlov merged 3 commits intopython:mainfrom
kumaraditya303:issue46469
Jan 22, 2022
Merged

bpo-46469: Make asyncio generic classes return GenericAlias#30777
asvetlov merged 3 commits intopython:mainfrom
kumaraditya303:issue46469

Conversation

@kumaraditya303
Copy link
Contributor

@kumaraditya303 kumaraditya303 commented Jan 22, 2022 •
edited by bedevere-bot
Loading

@JelleZijlstra
Copy link
Member

JelleZijlstra commented Jan 22, 2022

These methods have existed since 3.9, but apparently aren't documented. Should the fix be backported?

sobolevn
sobolevn reviewed Jan 22, 2022
View reviewed changes
Copy link
Member

@sobolevn sobolevn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should probably also add these types to

cpython/Lib/test/test_genericalias.py

Line 52 in 82c5322

generic_types = [type, tuple, list, dict, set, frozenset, enumerate,

@kumaraditya303
Copy link
Contributor Author

kumaraditya303 commented Jan 22, 2022

These methods have existed since 3.9, but apparently aren't documented. Should the fix be backported?

This should be backported.

@kumaraditya303
Copy link
Contributor Author

kumaraditya303 commented Jan 22, 2022

You should probably also add these types to

cpython/Lib/test/test_genericalias.py

Line 52 in 82c5322

generic_types = [type, tuple, list, dict, set, frozenset, enumerate,

There isn't any need to test it more than once and in the asyncio it tests both the c and python implementation so no need.

@asvetlov asvetlov merged commit ea5b968 into python:main Jan 22, 2022
@miss-islington
Copy link
Contributor

miss-islington commented Jan 22, 2022

Thanks @kumaraditya303 for the PR, and @asvetlov for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9, 3.10.
🐍🍒⛏🤖

@kumaraditya303 kumaraditya303 deleted the issue46469 branch January 22, 2022 11:29
@miss-islington
Copy link
Contributor

miss-islington commented Jan 22, 2022

Sorry, @kumaraditya303 and @asvetlov, I could not cleanly backport this to 3.9 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker ea5b96842e066623a53015d8b2492ed61a5baf96 3.9

@bedevere-bot
Copy link

bedevere-bot commented Jan 22, 2022

GH-30784 is a backport of this pull request to the 3.10 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label Jan 22, 2022
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 22, 2022
@kumaraditya303 @miss-islington
bpo-46469: Make asyncio generic classes return GenericAlias (pythonGH…
52fd95e 
…-30777)

* bpo-46469: Make asyncio generic classes return GenericAlias

* 📜🤖 Added by blurb_it.

* Update Misc/NEWS.d/next/Library/2022-01-22-05-05-08.bpo-46469.plUab5.rst

Co-authored-by: Jelle Zijlstra <[email protected]>

Co-authored-by: blurb-it[bot] <43283697+blurb-it[bot]@users.noreply.github.com>
Co-authored-by: Jelle Zijlstra <[email protected]>
(cherry picked from commit ea5b968)

Co-authored-by: Kumar Aditya <[email protected]>
@asvetlov
Copy link
Contributor

asvetlov commented Jan 22, 2022

Thanks. I'm constantly forgetting to make this change.

@bedevere-bot
Copy link

bedevere-bot commented Jan 22, 2022

GH-30785 is a backport of this pull request to the 3.9 branch.

kumaraditya303 added a commit to kumaraditya303/cpython that referenced this pull request Jan 22, 2022
@kumaraditya303
bpo-46469: Make asyncio generic classes return GenericAlias (pythonGH…
5adf7fe 
…-30777)
asvetlov added a commit that referenced this pull request Jan 22, 2022
@miss-islington @kumaraditya303 @asvetlov
[3.10] bpo-46469: Make asyncio generic classes return GenericAlias (G…
90e2998 
…H-30777) (#30784)

* bpo-46469: Make asyncio generic classes return GenericAlias (GH-30777)

* bpo-46469: Make asyncio generic classes return GenericAlias

* 📜🤖 Added by blurb_it.

* Update Misc/NEWS.d/next/Library/2022-01-22-05-05-08.bpo-46469.plUab5.rst

Co-authored-by: Jelle Zijlstra <[email protected]>

Co-authored-by: blurb-it[bot] <43283697+blurb-it[bot]@users.noreply.github.com>
Co-authored-by: Jelle Zijlstra <[email protected]>
(cherry picked from commit ea5b968)

Co-authored-by: Kumar Aditya <[email protected]>

* Fix tests

Co-authored-by: Kumar Aditya <[email protected]>
Co-authored-by: Andrew Svetlov <[email protected]>
miss-islington pushed a commit that referenced this pull request Jan 22, 2022
@kumaraditya303
[3.9] bpo-46469: Make asyncio generic classes return GenericAlias (GH…
6ed874f 
…-30777)  (GH-30785)

Automerge-Triggered-By: GH:asvetlov
@sobolevn sobolevn mentioned this pull request Jan 23, 2022
Merged
hello-adam pushed a commit to hello-adam/cpython that referenced this pull request Jun 2, 2022
@kumaraditya303 @hello-adam
[3.9] bpo-46469: Make asyncio generic classes return GenericAlias (py…
6a87c42 
…thonGH-30777)  (pythonGH-30785)

Automerge-Triggered-By: GH:asvetlov
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JelleZijlstra JelleZijlstra JelleZijlstra left review comments

@sobolevn sobolevn sobolevn left review comments

@asvetlov asvetlov asvetlov approved these changes

@1st1 1st1 Awaiting requested review from 1st1 1st1 is a code owner

@rhettinger rhettinger Awaiting requested review from rhettinger

Assignees

@asvetlov asvetlov

Labels

topic-asyncio

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@kumaraditya303 @JelleZijlstra @miss-islington @bedevere-bot @asvetlov @sobolevn @the-knights-who-say-ni