Skip to content

Comments

Test reviewdog/action-suggester#30070

Closed
tiran wants to merge 2 commits intopython:mainfrom
tiran:suggest_changes
Closed

Test reviewdog/action-suggester#30070
tiran wants to merge 2 commits intopython:mainfrom
tiran:suggest_changes

Conversation

@tiran
Copy link
Member

@tiran tiran commented Dec 12, 2021

No description provided.

@tiran
Copy link
Member Author

tiran commented Dec 12, 2021

The action cannot create suggestions, yet. Our GH token does not include write access to review API:

reviewdog: This GitHub token doesn't have write permission of Review API [1], 
so reviewdog will report results via logging command [2] and create annotations similar to
github-pr-check reporter as a fallback.
[1]: docs.github.com/en/actions/reference/events-that-trigger-workflows#pull_request_target
[2]: help.github.com/en/actions/automating-your-workflow-with-github-actions/development-tools-for-github-actions#logging-commands

@arhadthedev
Copy link
Member

arhadthedev commented Dec 12, 2021 •
edited
Loading

As far as I know GitHub once didn't allow to leave suggestions on untouched lines:

https://github.com/getsentry/action-git-diff-suggestions

This doesn't work as intended as you can not leave a review comment on lines that are not modified in the PR. Due to this limitation, this action can potentionally have undesired results.

This repository has been archived by the owner. It is now read-only.

However, looking at this screenshot in readme of action-suggester I suspect this limitation was fixed:

That's curious considering I haven't seen any related announcement on https://github.blog.

@arhadthedev
Copy link
Member

arhadthedev commented Dec 12, 2021

Our GH token does not include write access to review API

You can try to clone cpython into your profile and enable actions there.

@tiran
Copy link
Member Author

tiran commented Dec 12, 2021

action suggester is useless for our use case. It cannot add comments to files unless the file has been modified in the same PR.

@tiran tiran closed this Dec 12, 2021
@arhadthedev
Copy link
Member

arhadthedev commented Dec 15, 2021

For interlinking purposes: this PR is superseded with GH-30117.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@erlend-aasland erlend-aasland Awaiting requested review from erlend-aasland erlend-aasland will be requested when the pull request is marked ready for review erlend-aasland is a code owner

@corona10 corona10 Awaiting requested review from corona10 corona10 will be requested when the pull request is marked ready for review corona10 is a code owner

@AA-Turner AA-Turner Awaiting requested review from AA-Turner AA-Turner will be requested when the pull request is marked ready for review AA-Turner is a code owner

@emmatyping emmatyping Awaiting requested review from emmatyping emmatyping will be requested when the pull request is marked ready for review emmatyping is a code owner

@ezio-melotti ezio-melotti Awaiting requested review from ezio-melotti ezio-melotti will be requested when the pull request is marked ready for review ezio-melotti is a code owner

@hugovk hugovk Awaiting requested review from hugovk hugovk will be requested when the pull request is marked ready for review hugovk is a code owner

@webknjaz webknjaz Awaiting requested review from webknjaz webknjaz will be requested when the pull request is marked ready for review webknjaz is a code owner

Assignees

No one assigned

Labels

awaiting core review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@tiran @arhadthedev @the-knights-who-say-ni @bedevere-bot