Skip to content

Comments

bpo-42740: Support PEP 604, 612 for typing.py get_args and get_origin#23942

Merged
gvanrossum merged 4 commits intopython:masterfrom
Fidget-Spinner:get-args-origin
Dec 29, 2020
Merged

bpo-42740: Support PEP 604, 612 for typing.py get_args and get_origin#23942
gvanrossum merged 4 commits intopython:masterfrom
Fidget-Spinner:get-args-origin

Conversation

@Fidget-Spinner
Copy link
Member

@Fidget-Spinner Fidget-Spinner commented Dec 25, 2020 •
edited by miss-islington
Loading

PR 2/2. No backport required.

https://bugs.python.org/issue42740

Automerge-Triggered-By: GH:gvanrossum

@Fidget-Spinner Fidget-Spinner changed the title Support PEP 604 and PEP 612 for typing.py get_args and get_origin bpo-42740: Support PEP 604 and PEP 612 for typing.py get_args and get_origin Dec 25, 2020
@Fidget-Spinner Fidget-Spinner changed the title bpo-42740: Support PEP 604 and PEP 612 for typing.py get_args and get_origin bpo-42740: Support PEP 604, 612 for typing.py get_args and get_origin Dec 25, 2020
@Fidget-Spinner Fidget-Spinner marked this pull request as draft December 26, 2020 06:43
@Fidget-Spinner Fidget-Spinner marked this pull request as ready for review December 27, 2020 09:49
gvanrossum
gvanrossum approved these changes Dec 28, 2020
View reviewed changes
Copy link
Member

@gvanrossum gvanrossum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Presumably this will cause a merge conflict now that I've merged the first one?

@miss-islington
Copy link
Contributor

miss-islington commented Dec 29, 2020

@Fidget-Spinner: Status check is done, and it's a success ✅ .

1 similar comment
@miss-islington
Copy link
Contributor

miss-islington commented Dec 29, 2020

@Fidget-Spinner: Status check is done, and it's a success ✅ .

@miss-islington
Copy link
Contributor

miss-islington commented Dec 29, 2020

Sorry, I can't merge this PR. Reason: Base branch was modified. Review and try the merge again..

@miss-islington
Copy link
Contributor

miss-islington commented Dec 29, 2020

Sorry, I can't merge this PR. Reason: 2 of 4 required status checks are expected..

@miss-islington
Copy link
Contributor

miss-islington commented Dec 29, 2020

@Fidget-Spinner: Status check is done, and it's a success ❌ .

@miss-islington
Copy link
Contributor

miss-islington commented Dec 29, 2020

@Fidget-Spinner: Status check is done, and it's a success ❌ .

2 similar comments
@miss-islington
Copy link
Contributor

miss-islington commented Dec 29, 2020

@Fidget-Spinner: Status check is done, and it's a success ❌ .

@miss-islington
Copy link
Contributor

miss-islington commented Dec 29, 2020

@Fidget-Spinner: Status check is done, and it's a success ❌ .

gvanrossum
gvanrossum approved these changes Dec 29, 2020
View reviewed changes
Copy link
Member

@gvanrossum gvanrossum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving again, maybe that unblocks miss-islington.

@gvanrossum gvanrossum removed the request for review from ilevkivskyi December 29, 2020 02:25
@gvanrossum gvanrossum merged commit efb1f09 into python:master Dec 29, 2020
@Fidget-Spinner Fidget-Spinner deleted the get-args-origin branch December 29, 2020 02:29
@Fidget-Spinner Fidget-Spinner mentioned this pull request Dec 29, 2020
Merged
adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 13, 2021
@Fidget-Spinner @adorilson
bpo-42740: Support PEP 604, 612 for typing.py get_args and get_origin (…
46bc3be 
…pythonGH-23942)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gvanrossum gvanrossum gvanrossum approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Fidget-Spinner @miss-islington @gvanrossum @the-knights-who-say-ni @bedevere-bot