bpo-24813: IDLE: Add icon to help_about#2335
Merged
terryjreedy merged 3 commits intopython:masterfrom Jun 23, 2017
Merged
Conversation
terryjreedy
requested changes
Jun 23, 2017
Member
terryjreedy
left a comment
terryjreedy
left a comment
There was a problem hiding this comment.
I forgot to specify icon to left (this is standard), 'IDLE' to its right (in current center). With this position switch and 1 name change, PR will be ready to merge.
Lib/idlelib/help_about.py
Outdated
|
|
||
| tk_patchlevel = self.tk.call('info', 'patchlevel') | ||
| ext = '.png' if tk_patchlevel >= '8.6' else '.gif' | ||
| iconfn = os.path.join(os.path.abspath(os.path.dirname(__file__)), |
Member
There was a problem hiding this comment.
I suspect 'iconfn' abbreviates 'icon file name'. Too obscure; I'd prefer 'icon' here and below.
| """Test about dialog logo.""" | ||
| path, file = os.path.split(self.dialog.icon_image['file']) | ||
| fn, ext = os.path.splitext(file) | ||
| self.assertEqual(fn, 'idle_48') |
Member
There was a problem hiding this comment.
This is the best I can think of too. The real test is running help_about for the htest. I did that to experiment with different backgrounds.
Contributor
Author
There was a problem hiding this comment.
Thanks. I wasn't sure if I should mock the PhotoImage just to show that the widget is created.
Contributor
Author
|
Thanks. Looks better now. :-) |
terryjreedy
approved these changes
Jun 23, 2017
terryjreedy
pushed a commit
to terryjreedy/cpython
that referenced
this pull request
Jun 23, 2017
Patch by Cheryl Sabella (cherry picked from commit d352d68)
terryjreedy
added a commit
that referenced
this pull request
Jun 23, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on part of a patch originally by Mark Roseman.