bpo-30604: clean up co_extra support#2144
Merged
1st1 merged 4 commits intopython:masterfrom Jun 21, 2017
DinoV:30636
Merged
Conversation
|
@DinoV, thanks for your PR! By analyzing the history of the files in this pull request, we identified @mhammond, @benjaminp and @serhiy-storchaka to be potential reviewers. |
brettcannon
changed the title
brettcannon
approved these changes
Jun 13, 2017
Member
brettcannon
left a comment
brettcannon
left a comment
There was a problem hiding this comment.
I updated the NEWS entry, but otherwise LGTM.
1st1
reviewed
Jun 21, 2017
Objects/codeobject.c
Outdated
| { | ||
| if (co->co_extra != NULL) { | ||
| PyThreadState *tstate = PyThreadState_Get(); | ||
| PyInterpreterState *interp= PyThreadState_Get()->interp; |
Member
There was a problem hiding this comment.
Never mind, I figured I can fix this myself :)
1st1
approved these changes
Jun 21, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
bpo-30604: port fix from 3.6 dropping binary compatibility tweaks