Skip to content

Comments

bpo-21161: pdb: default: handle list comprehensions#15194

Closed
blueyed wants to merge 1 commit intopython:mainfrom
blueyed:pdb-list-comprehensions
Closed

bpo-21161: pdb: default: handle list comprehensions#15194
blueyed wants to merge 1 commit intopython:mainfrom
blueyed:pdb-list-comprehensions

Conversation

@blueyed
Copy link
Contributor

@blueyed blueyed commented Aug 9, 2019 •
edited
Loading

Fixes https://bugs.python.org/issue21161.

TODO:

  • test
  • news
  • attribute patch author (Xavier de Gaye (xdegaye), @xdegaye)

https://bugs.python.org/issue21161

@blueyed
Copy link
Contributor Author

blueyed commented Aug 9, 2019 •
edited
Loading

test_gdb crashed on Azure (https://dev.azure.com/Python/cpython/_build/results?buildId=48361&view=logs&j=c83831cd-3752-5cc7-2f01-8276919eb334):

0:12:45 load avg: 0.01 [418/419] test_io passed (4 min 23 sec) -- running: test_gdb (10 min 1 sec)
running: test_gdb (10 min 31 sec)
running: test_gdb (11 min 1 sec)
running: test_gdb (11 min 31 sec)
running: test_gdb (15 min 31 sec)
running: test_gdb (16 min 1 sec)
running: test_gdb (16 min 31 sec)
running: test_gdb (17 min 1 sec)
running: test_gdb (17 min 31 sec)
running: test_gdb (18 min 1 sec)
running: test_gdb (18 min 31 sec)
running: test_gdb (19 min 1 sec)
running: test_gdb (19 min 31 sec)
Timeout (0:20:00)!
0:22:44 load avg: 0.00 [419/419/1] test_gdb crashed (Exit code 1)
Thread 0x00000fa4 (most recent call first):
File "D:\a\1\s\lib\subprocess.py", line 1353 in _readerthread
File "D:\a\1\s\lib\threading.py", line 876 in run
File "D:\a\1\s\lib\threading.py", line 938 in _bootstrap_inner
File "D:\a\1\s\lib\threading.py", line 896 in _bootstrap
Thread 0x000003f4 (most recent call first):
File "D:\a\1\s\lib\subprocess.py", line 1353 in _readerthread
File "D:\a\1\s\lib\threading.py", line 876 in run
File "D:\a\1\s\lib\threading.py", line 938 in _bootstrap_inner
File "D:\a\1\s\lib\threading.py", line 896 in _bootstrap
Thread 0x00000a7c (most recent call first):
File "D:\a\1\s\lib\threading.py", line 1033 in _wait_for_tstate_lock
File "D:\a\1\s\lib\threading.py", line 1017 in join
File "D:\a\1\s\lib\subprocess.py", line 1382 in _communicate
File "D:\a\1\s\lib\subprocess.py", line 1015 in communicate
File "D:\a\1\s\lib\test\test_gdb.py", line 105 in run_gdb
File "D:\a\1\s\lib\test\test_gdb.py", line 122 in gdb_has_frame_select
File "D:\a\1\s\lib\test\test_gdb.py", line 129 in <module>
File "<frozen importlib._bootstrap>", line 219 in _call_with_frames_removed
File "<frozen importlib._bootstrap_external>", line 782 in exec_module
== Tests result: FAILURE ==

(retrying)

@blueyed blueyed force-pushed the pdb-list-comprehensions branch from 00fac9a to ff84fb3 Compare August 12, 2019 01:16
@viniciusd
Copy link

viniciusd commented Aug 21, 2019

Congrats for the work here :)
It looks to me it covers other kinds of comprehensions as well, right? Like set and dictionary comprehension. What do you think of also testing those?

@blueyed
Copy link
Contributor Author

blueyed commented Aug 21, 2019

What do you think of also testing those?

I do not think it is necessary really - the test proves that the namespace is handled properly/differently already.

epicfaace
epicfaace reviewed Aug 24, 2019
View reviewed changes
Lib/test/test_pdb.py
def test_list_comprehensions(self):
script = """
def f():
mylocal = "init_mylocal" # noqa: F841
Copy link
Contributor

@epicfaace epicfaace Aug 24, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does the comment mean?

Copy link

@gogobd gogobd Feb 16, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Local variable name is assigned to but never used (F841)

Lib/test/test_pdb.py
commands = """
continue

p "mylocal:" + mylocal
Copy link
Contributor

@epicfaace epicfaace Aug 24, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you need this line in the test?

@ccordoba12 ccordoba12 mentioned this pull request Oct 3, 2020
Closed
10 tasks
@impact27 impact27 mentioned this pull request Oct 3, 2020
Merged
@sweeneyde sweeneyde mentioned this pull request Sep 26, 2021
Closed
impact27
impact27 reviewed Sep 29, 2021
View reviewed changes
Lib/pdb.py
if line[:1] == '!': line = line[1:]
locals = self.curframe_locals
globals = self.curframe.f_globals
ns = self.curframe.f_globals.copy()
Copy link
Contributor

@impact27 impact27 Sep 29, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What it the code that is being debugged changes globals()? This would mean any changes to self.curframe.f_globals by the calling code is dropped, is it not?

@kay kay mannequin mentioned this pull request Jan 11, 2023
Closed
@erlend-aasland
Copy link
Contributor

erlend-aasland commented May 6, 2024

The linked issue was fixed by #111094; closing this since the linked issue is now resolved.

Thanks for your interest in improving CPython!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

3 more reviewers

@gogobd gogobd gogobd left review comments

@epicfaace epicfaace epicfaace left review comments

@impact27 impact27 impact27 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

awaiting review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@blueyed @viniciusd @erlend-aasland @gogobd @epicfaace @impact27 @the-knights-who-say-ni @ezio-melotti @bedevere-bot