Skip to content

Comments

gh-144601: Avoid sharing exception objects raised in a PyInit function across multiple interpreters#144602

Merged
encukou merged 4 commits intopython:mainfrom
ZeroIntensity:subinterp-import-crash
Feb 9, 2026
Merged

gh-144601: Avoid sharing exception objects raised in a PyInit function across multiple interpreters#144602
encukou merged 4 commits intopython:mainfrom
ZeroIntensity:subinterp-import-crash

Conversation

@ZeroIntensity
Copy link
Member

@ZeroIntensity ZeroIntensity commented Feb 8, 2026 •
edited by bedevere-app bot
Loading

@ZeroIntensity ZeroIntensity added the needs backport to 3.13 bugs and security fixes label Feb 8, 2026
@ZeroIntensity ZeroIntensity added the needs backport to 3.14 bugs and security fixes label Feb 8, 2026
@bedevere-app bedevere-app bot mentioned this pull request Feb 8, 2026
Closed
encukou
encukou approved these changes Feb 9, 2026
View reviewed changes
Copy link
Member

@encukou encukou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@encukou encukou merged commit fd6b639 into python:main Feb 9, 2026
59 checks passed
@miss-islington-app
Copy link

miss-islington-app bot commented Feb 9, 2026

Thanks @ZeroIntensity for the PR, and @encukou for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Feb 9, 2026
@ZeroIntensity @miss-islington
pythongh-144601: Avoid sharing exception objects raised in a PyInit…
7725c61 
… function across multiple interpreters (pythonGH-144602)

(cherry picked from commit fd6b639)

Co-authored-by: Peter Bierma <[email protected]>
@miss-islington-app
Copy link

miss-islington-app bot commented Feb 9, 2026

Sorry, @ZeroIntensity and @encukou, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker fd6b639a49dd1143c6fd8729fc49f17b3114a965 3.13

@bedevere-app
Copy link

bedevere-app bot commented Feb 9, 2026

GH-144633 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.14 bugs and security fixes label Feb 9, 2026
@bedevere-bot
Copy link

bedevere-bot commented Feb 9, 2026

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot s390x Fedora Stable Clang Installed 3.x (tier-3) has failed when building commit fd6b639.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/1645/builds/2096) and take a look at the build logs.
  4. Check if the failure is related to this commit (fd6b639) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/1645/builds/2096

Summary of the results of the build (if available):

Click to see traceback logs 
fatal: unable to access 'https://github.com/python/cpython.git/': The requested URL returned error: 502

chmod: cannot access 'target/': No such file or directory

make: *** No rule to make target 'distclean'.  Stop.

@encukou
Copy link
Member

encukou commented Feb 9, 2026

GitHub is having issues; that builder got a 502 Bad Gateway.

@bedevere-bot
Copy link

bedevere-bot commented Feb 9, 2026

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot AMD64 Fedora Stable Clang Installed 3.x (tier-2) has failed when building commit fd6b639.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/350/builds/9323) and take a look at the build logs.
  4. Check if the failure is related to this commit (fd6b639) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/350/builds/9323

Summary of the results of the build (if available):

Click to see traceback logs 
fatal: unable to access 'https://github.com/python/cpython.git/': The requested URL returned error: 502

chmod: cannot access 'target/': No such file or directory

make: *** No rule to make target 'distclean'.  Stop.

@ZeroIntensity ZeroIntensity deleted the subinterp-import-crash branch February 11, 2026 02:11
@ZeroIntensity ZeroIntensity mentioned this pull request Feb 12, 2026
Merged
thunder-coding pushed a commit to thunder-coding/cpython that referenced this pull request Feb 15, 2026
@ZeroIntensity @thunder-coding
pythongh-144601: Avoid sharing exception objects raised in a PyInit…
bf9df37 
… function across multiple interpreters (pythonGH-144602)
ZeroIntensity added a commit that referenced this pull request Feb 16, 2026
@miss-islington @ZeroIntensity
[3.14] gh-144601: Avoid sharing exception objects raised in a `PyInit…
907958c 
…` function across multiple interpreters (GH-144602) (GH-144633)

gh-144601: Avoid sharing exception objects raised in a `PyInit` function across multiple interpreters (GH-144602)
(cherry picked from commit fd6b639)

Co-authored-by: Peter Bierma <[email protected]>
ZeroIntensity added a commit to ZeroIntensity/cpython that referenced this pull request Feb 16, 2026
@ZeroIntensity
[3.13] pythongh-144601: Avoid sharing exception objects raised in a `…
1b2c2a4 
…PyInit` function across multiple interpreters (pythonGH-144602)

(cherry picked from commit fd6b639)

Co-authored-by: Peter Bierma <[email protected]>
@bedevere-app
Copy link

bedevere-app bot commented Feb 16, 2026

GH-144880 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Feb 16, 2026
ZeroIntensity added a commit to ZeroIntensity/cpython that referenced this pull request Feb 16, 2026
@miss-islington @ZeroIntensity
[3.13] pythongh-144601: Avoid sharing exception objects raised in a `…
b00f9b0 
…PyInit` function across multiple interpreters (pythonGH-144602) (pythonGH-144633)

pythongh-144601: Avoid sharing exception objects raised in a `PyInit` function across multiple interpreters (pythonGH-144602)
(cherry picked from commit fd6b639)
(cherry picked from commit 907958c)

Co-authored-by: Miss Islington (bot) <[email protected]>
Co-authored-by: Peter Bierma <[email protected]>
ZeroIntensity added a commit that referenced this pull request Feb 16, 2026
@ZeroIntensity
[3.13] gh-144601: Avoid sharing exception objects raised in a `PyInit…
9314ec2 
…` function across multiple interpreters (GH-144602) (GH-144880)

(cherry picked from commit fd6b639)
This was referenced Feb 16, 2026
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@encukou encukou encukou approved these changes

@ericsnowcurrently ericsnowcurrently Awaiting requested review from ericsnowcurrently ericsnowcurrently is a code owner

@brettcannon brettcannon Awaiting requested review from brettcannon brettcannon is a code owner

@ncoghlan ncoghlan Awaiting requested review from ncoghlan ncoghlan is a code owner

@warsaw warsaw Awaiting requested review from warsaw warsaw is a code owner

@kumaraditya303 kumaraditya303 Awaiting requested review from kumaraditya303 kumaraditya303 is a code owner

Assignees

@encukou encukou

Labels

topic-subinterpreters

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ZeroIntensity @bedevere-bot @encukou