gh-143923: Reject control characters in POP3 commands#143924
Merged
sethmlarson merged 2 commits intopython:mainfrom Jan 20, 2026
Merged
gh-143923: Reject control characters in POP3 commands#143924sethmlarson merged 2 commits intopython:mainfrom
sethmlarson merged 2 commits intopython:mainfrom
Conversation
sethmlarson
added
type-security
Member
|
Here I have a backward compatibility concern. While the RFC makes it clear that non-printables other than space are not acceptable in commands, I can imagine people using passwords with things like tab and backspace in them, and while that would violate the RFC, it would currently work, and this would break that. What do you think? Note that since this is the client side, this is not, IMO, a security issue, it's more of an RFC conformance issue. |
Member
|
Yeah, I agree. This is fine on main but I'm not sure I'd backport it, even as a bugfix. |
sethmlarson
removed
needs backport to 3.10
Contributor
Author
|
For now we'll hold off on backporting this PR as they are potentially breaking some existing behavior. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.