GH-141509: Fix warning about remaining subinterpreters#141528
Conversation
sergey-miryanov
requested review from
ZeroIntensity and
ericsnowcurrently
as code owners
ZeroIntensity
left a comment
ZeroIntensity
left a comment
There was a problem hiding this comment.
- This changes a public API, so let's add a news entry.
- Since you didn't need to update any tests, that means that this code path is untested. Please add a test case for leaving subinterpreters unclosed.
|
Tests fail because of #131229 |
|
@ZeroIntensity Could you please take a look? |
Misc/NEWS.d/next/Core_and_Builtins/2025-11-14-00-19-45.gh-issue-141528.VWdax1.rst
Outdated
Show resolved
Hide resolved
…e-141528.VWdax1.rst Co-authored-by: Peter Bierma <[email protected]>
|
Fixed. Please take a look. |
|
Thanks! |
Ugh, that seems to fail consistently. I can't merge this until that job passes. |
|
Yeah, I'm looking into it, but without luck yet. |
|
I reran the UBSan job (where test_import was failing). |
|
I did too, but it still failed. It might pass if we rerun it enough times. See #141552 for a skip. |
|
Thanks @sergey-miryanov for the PR, and @ZeroIntensity for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14. |
|
Sorry, @sergey-miryanov and @ZeroIntensity, I could not cleanly backport this to |
|
@sergey-miryanov Could you handle the backport? |
|
@ZeroIntensity Yeah, sure. |
|
GH-141566 is a backport of this pull request to the 3.14 branch. |
…ythonGH-141528) (cherry picked from commit fa245df) Co-authored-by: Sergey Miryanov <[email protected]> Co-authored-by: Peter Bierma <[email protected]>
) (GH-141566) (cherry picked from commit fa245df) Co-authored-by: Peter Bierma <[email protected]>
|
Thanks for review! |
…H-141528) Co-authored-by: Peter Bierma <[email protected]>
3 participants
Fix warning - suggest using
Interpreter.closeinstead of_interpeters.destroy.@ZeroIntensity Could you please take a look?