Skip to content

bpo-36707: Document "m" removed from sys.abiflags#14090

Merged
vstinner merged 3 commits intopython:masterfrom
vstinner:abiflags_m_doc
Jun 15, 2019
Merged

bpo-36707: Document "m" removed from sys.abiflags#14090
vstinner merged 3 commits intopython:masterfrom
vstinner:abiflags_m_doc

Conversation

@vstinner
Copy link
Member

@vstinner vstinner commented Jun 14, 2019 •
edited by bedevere-bot
Loading

@bedevere-bot bedevere-bot added docs Documentation in the Doc dir awaiting core review labels Jun 14, 2019
@vstinner
Copy link
Member Author

vstinner commented Jun 14, 2019

@hroncok @ned-deily: Would you mind to review this doc change?

@vstinner vstinner requested a review from ned-deily June 14, 2019 16:52
ned-deily
ned-deily reviewed Jun 14, 2019
View reviewed changes
Doc/whatsnew/3.8.rst Outdated
Copy link
Member

@ned-deily ned-deily Jun 14, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should also be noted that this affects extension modules in the standard library as well as those produced and installed by third-party packages, like those downloaded from PyPI.

Copy link
Member Author

@vstinner vstinner Jun 14, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I updated my PR. Does it look better now?

@vstinner
Copy link
Member Author

vstinner commented Jun 14, 2019

I rebased my PR to fix a conflict.

ned-deily
ned-deily approved these changes Jun 14, 2019
View reviewed changes
Copy link
Member

@ned-deily ned-deily left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My preference remains to not make the flags change at all but, if we must, this documents it adequately, I think. :). Thanks!

yan12125
yan12125 reviewed Jun 14, 2019
View reviewed changes
@vstinner
Copy link
Member Author

vstinner commented Jun 15, 2019

My preference remains to not make the flags change at all

Well, "m" in ABI flags became useless around Python 3.4. I don't see the point of pretending that the "m" ABI is different and then provide two names for the same thing:

  • python3.8 and python3.8m
  • python3.8-config and python3.8m-config
  • man python3.8 and man python3.8m
  • etc.

I'm not sure why, but on Fedora /usr/bin/python3.7 and /usr/bin/python3.7m are two separated files... with the same content (ex: same MD5 sum). Well, it's just 17 KiB each :-) /usr/bin/python3.7-config is a symlink to python3.7m-config.

The change itself is painful for distributors like Red Hat (Fedora, RHEL), but things should be simpler once the change is done.

My long-term goal is to get a single ABI for everything: CPython, PyPy, RustPython, MicroPython, etc. :-) Maybe it's not possible, but at least I would like to move towards this goal!

Overall project: https://pythoncapi.readthedocs.io/

@vstinner vstinner merged commit 7efc526 into python:master Jun 15, 2019
@miss-islington
Copy link
Contributor

miss-islington commented Jun 15, 2019

Thanks @vstinner for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

@vstinner vstinner deleted the abiflags_m_doc branch June 15, 2019 01:24
@vstinner
Copy link
Member Author

vstinner commented Jun 15, 2019

Thanks @ned-deily and @yan12125 for the review ;-)

@bedevere-bot
Copy link

bedevere-bot commented Jun 15, 2019

GH-14097 is a backport of this pull request to the 3.8 branch.

miss-islington added a commit that referenced this pull request Jun 15, 2019
@miss-islington @vstinner
bpo-36707: Document "m" removal from sys.abiflags (GH-14090)
3fde750 
(cherry picked from commit 7efc526)

Co-authored-by: Victor Stinner <[email protected]>
hroncok
hroncok reviewed Jun 15, 2019
View reviewed changes
Copy link
Contributor

@hroncok hroncok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, sorry for not responding faster

lisroach pushed a commit to lisroach/cpython that referenced this pull request Sep 10, 2019
@vstinner @lisroach
bpo-36707: Document "m" removal from sys.abiflags (pythonGH-14090)
f0d2659
DinoV pushed a commit to DinoV/cpython that referenced this pull request Jan 14, 2020
@vstinner @DinoV
bpo-36707: Document "m" removal from sys.abiflags (pythonGH-14090)
fb551d8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ned-deily ned-deily ned-deily approved these changes

+2 more reviewers

@yan12125 yan12125 yan12125 left review comments

@hroncok hroncok hroncok left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@vstinner @miss-islington @bedevere-bot @yan12125 @hroncok @ned-deily @the-knights-who-say-ni