GH-140815: Acquire GIL or stop the world when calling _Py_DumpTracebackThreads from faulthandler_thread#140895
Closed
sergey-miryanov wants to merge 4 commits intopython:mainfrom
Closed
Conversation
…rom faulthandler_thread
sergey-miryanov
commented
Nov 1, 2025
sergey-miryanov
commented
Nov 1, 2025
Member
|
I don't think that this change is correct. By design, faulthandler can be called on a deadlock. It should be able to dump the Python traceback without acquiring any kind of lock since Python may already been blocked somehow. I wrote a different fix #140921 to detect invalid/freed frame or code object. |
Contributor
Author
|
Yeah, if we should avoid any locking at all costs then this fix is not correct. I will close this one and take a look at your #140921. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mostly a PoC now.
skip_current_tstatewas added to prevent the modification of tests that use the check_dump_traceback_later function. The faulthandler_thread is now in the traceback and has no Python frames, so the output of those tests may change. This is okay, as the faulthandler_thread doesn't have one.faulthandler.dump_traceback_later#140815