bpo-37269: Correctly optimize constant conditionals of binops#14071
Merged
pablogsal merged 4 commits intopython:masterfrom Jun 14, 2019
Merged
bpo-37269: Correctly optimize constant conditionals of binops#14071pablogsal merged 4 commits intopython:masterfrom
pablogsal merged 4 commits intopython:masterfrom
Conversation
Contributor
|
Thanks @pablogsal for the PR 🌮🎉.. I'm working now to backport this PR to: 3.7, 3.8. |
|
GH-14072 is a backport of this pull request to the 3.8 branch. |
Contributor
|
Sorry, @pablogsal, I could not cleanly backport this to |
|
GH-14073 is a backport of this pull request to the 3.7 branch. |
pablogsal
added a commit
to pablogsal/cpython
that referenced
this pull request
Jun 14, 2019
…ns (pythonGH-14071) Fix a regression introduced by af8646c that was causing code of the form: if True and False: do_something() to be optimized incorrectly, eliminating the block.. (cherry picked from commit 05f8318) Co-authored-by: Pablo Galindo <[email protected]>
miss-islington
added a commit
that referenced
this pull request
Jun 14, 2019
…-14071) Fix a regression introduced by af8646c that was causing code of the form: if True and False: do_something() to be optimized incorrectly, eliminating the block. (cherry picked from commit 05f8318) Co-authored-by: Pablo Galindo <[email protected]>
pablogsal
added a commit
that referenced
this pull request
Jun 14, 2019
…ns (GH-14071) (GH-14073) Fix a regression introduced by af8646c that was causing code of the form: if True and False: do_something() to be optimized incorrectly, eliminating the block.. (cherry picked from commit 05f8318) Co-authored-by: Pablo Galindo <[email protected]>
lisroach
pushed a commit
to lisroach/cpython
that referenced
this pull request
Sep 10, 2019
…thonGH-14071) Fix a regression introduced by af8646c that was causing code of the form: if True and False: do_something() to be optimized incorrectly, eliminating the block.
DinoV
pushed a commit
to DinoV/cpython
that referenced
this pull request
Jan 14, 2020
…thonGH-14071) Fix a regression introduced by af8646c that was causing code of the form: if True and False: do_something() to be optimized incorrectly, eliminating the block.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue37269