[3.8] bpo-37213: Handle negative line deltas correctly in the peephole optimizer (GH-13969)#14063
Merged
miss-islington merged 1 commit intopython:3.8from Jun 13, 2019
Merged
Conversation
…mizer (pythonGH-13969) The peephole optimizer was not optimizing correctly bytecode after negative deltas were introduced. This is due to the fact that some special values (255) were being searched for in both instruction pointer delta and line number deltas. (cherry picked from commit 3498c64) Co-authored-by: Pablo Galindo <[email protected]>
pablogsal
approved these changes
Jun 13, 2019
Contributor
Author
|
@pablogsal: Status check is done, and it's a success ✅ . |
Contributor
Author
|
@pablogsal: Status check is done, and it's a success ✅ . |
1 similar comment
Contributor
Author
|
@pablogsal: Status check is done, and it's a success ✅ . |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The peephole optimizer was not optimizing correctly bytecode after negative deltas were introduced. This is due to the fact that some special values (255) were being searched for in both instruction pointer delta and line number deltas.
(cherry picked from commit 3498c64)
Co-authored-by: Pablo Galindo [email protected]
https://bugs.python.org/issue37213