Skip to content

Comments

GH-139193: Fix dump_stack when PYTHON_LLTRACE=4#139384

Merged
markshannon merged 7 commits intopython:mainfrom
sergey-miryanov:139193-fix-dump-stack
Oct 22, 2025
Merged

GH-139193: Fix dump_stack when PYTHON_LLTRACE=4#139384
markshannon merged 7 commits intopython:mainfrom
sergey-miryanov:139193-fix-dump-stack

Conversation

@sergey-miryanov
Copy link
Contributor

@sergey-miryanov sergey-miryanov commented Sep 27, 2025 •
edited
Loading

There are two problems:

  1. dump_stack/dump_item should ignore items that pushed on the stack with PyStackRef_Wrap
  2. PyStackRef_IsError should test only Py_TAG_BITS of .bits not whole .bits value

Also, PyStackRef_IsValid should be fixed accordingly.

@bedevere-app bedevere-app bot mentioned this pull request Sep 27, 2025
Closed
@sergey-miryanov
Copy link
Contributor Author

sergey-miryanov commented Sep 27, 2025

PR ready to review, please take a look.

Fidget-Spinner
Fidget-Spinner approved these changes Sep 27, 2025
View reviewed changes
Copy link
Member

@Fidget-Spinner Fidget-Spinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@sergey-miryanov
Copy link
Contributor Author

sergey-miryanov commented Sep 28, 2025

@Fidget-Spinner Thanks for review! I tried to fix PyStackRef_IsValid accordingly, because I oversight it yesterday.

@sergey-miryanov
Copy link
Contributor Author

sergey-miryanov commented Sep 28, 2025

I revert it because it was not right.

@markshannon
Copy link
Member

markshannon commented Sep 30, 2025

PyStackRef_IsError should return true only for PyStackRef_ERROR

@markshannon
Copy link
Member

markshannon commented Sep 30, 2025

Any suggestions for a better name are welcome, as it is obviously not clear.

@sergey-miryanov
Copy link
Contributor Author

sergey-miryanov commented Oct 1, 2025

@markshannon What do you think about adding new function PyStackRef_IsInvalid to check is INVALID bit is set or no? And fix PyStackRef_IsError to check as you said above?

@markshannon
Copy link
Member

markshannon commented Oct 3, 2025

@markshannon What do you think about adding new function PyStackRef_IsInvalid to check is INVALID bit is set or no? And fix PyStackRef_IsError to check as you said above?

That sounds good. Leave PyStackRef_IsError untouched and add PyStackRef_IsMalformed.
It is tricky choosing a name that indicates that the stackef is broken, not that the ref is correct but thing it refers to is broken.
I think "malformed" conveys that a bit better than "invalid", but feel free to pick the name you think is clearest.

@sergey-miryanov
Copy link
Contributor Author

sergey-miryanov commented Oct 7, 2025

@markshannon Please take a look. I have added PyStackRef_IsMalformed for default and no-gil builds. For Py_STACKREF_DEBUG we can add it after gh-139475 merged.

@sergey-miryanov sergey-miryanov mentioned this pull request Oct 7, 2025
Merged
@Fidget-Spinner Fidget-Spinner mentioned this pull request Oct 21, 2025
Merged
@markshannon
Copy link
Member

markshannon commented Oct 22, 2025

Thanks for doing this

@markshannon markshannon merged commit a4709e5 into python:main Oct 22, 2025
51 checks passed
@sergey-miryanov
Copy link
Contributor Author

sergey-miryanov commented Oct 22, 2025

Thanks everyone for reviews!

@bedevere-bot
Copy link

bedevere-bot commented Oct 22, 2025

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot x86 Debian Non-Debug with X 3.x (no tier) has failed when building commit a4709e5.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/#/builders/1245/builds/6677) and take a look at the build logs.
  4. Check if the failure is related to this commit (a4709e5) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/#/builders/1245/builds/6677

Summary of the results of the build (if available):

==

Click to see traceback logs 
Traceback (most recent call last):
  File �[35m"/buildbot/buildarea/3.x.ware-debian-x86.nondebug/build/Lib/contextlib.py"�[0m, line �[35m85�[0m, in �[35minner�[0m
    return func(*args, **kwds)
  File �[35m"/buildbot/buildarea/3.x.ware-debian-x86.nondebug/build/Lib/test/_test_multiprocessing.py"�[0m, line �[35m596�[0m, in �[35mtest_interrupt�[0m
    exitcode = self._kill_process(multiprocessing.Process.interrupt)
  File �[35m"/buildbot/buildarea/3.x.ware-debian-x86.nondebug/build/Lib/contextlib.py"�[0m, line �[35m85�[0m, in �[35minner�[0m
    return func(*args, **kwds)
  File �[35m"/buildbot/buildarea/3.x.ware-debian-x86.nondebug/build/Lib/test/_test_multiprocessing.py"�[0m, line �[35m577�[0m, in �[35m_kill_process�[0m
    self.assertEqual(�[31mjoin�[0m�[1;31m()�[0m, None)
                     �[31m~~~~�[0m�[1;31m^^�[0m
  File �[35m"/buildbot/buildarea/3.x.ware-debian-x86.nondebug/build/Lib/test/_test_multiprocessing.py"�[0m, line �[35m250�[0m, in �[35m__call__�[0m
    return �[31mself.func�[0m�[1;31m(*args, **kwds)�[0m
           �[31m~~~~~~~~~�[0m�[1;31m^^^^^^^^^^^^^^^�[0m
  File �[35m"/buildbot/buildarea/3.x.ware-debian-x86.nondebug/build/Lib/multiprocessing/process.py"�[0m, line �[35m156�[0m, in �[35mjoin�[0m
    res = self._popen.wait(timeout)
  File �[35m"/buildbot/buildarea/3.x.ware-debian-x86.nondebug/build/Lib/multiprocessing/popen_fork.py"�[0m, line �[35m44�[0m, in �[35mwait�[0m
    return �[31mself.poll�[0m�[1;31m(os.WNOHANG if timeout == 0.0 else 0)�[0m
           �[31m~~~~~~~~~�[0m�[1;31m^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^�[0m
  File �[35m"/buildbot/buildarea/3.x.ware-debian-x86.nondebug/build/Lib/multiprocessing/popen_fork.py"�[0m, line �[35m28�[0m, in �[35mpoll�[0m
    pid, sts = �[31mos.waitpid�[0m�[1;31m(self.pid, flag)�[0m
               �[31m~~~~~~~~~~�[0m�[1;31m^^^^^^^^^^^^^^^^�[0m
  File �[35m"/buildbot/buildarea/3.x.ware-debian-x86.nondebug/build/Lib/test/_test_multiprocessing.py"�[0m, line �[35m573�[0m, in �[35mhandler�[0m
    raise RuntimeError('join took too long: %s' % p)
�[1;35mRuntimeError�[0m: �[35mjoin took too long: <Process name='Process-1' pid=2952 parent=2950 started daemon>�[0m


Traceback (most recent call last):
  File �[35m"/buildbot/buildarea/3.x.ware-debian-x86.nondebug/build/Lib/contextlib.py"�[0m, line �[35m85�[0m, in �[35minner�[0m
    return func(*args, **kwds)
  File �[35m"/buildbot/buildarea/3.x.ware-debian-x86.nondebug/build/Lib/test/_test_multiprocessing.py"�[0m, line �[35m596�[0m, in �[35mtest_interrupt�[0m
    exitcode = self._kill_process(multiprocessing.Process.interrupt)
  File �[35m"/buildbot/buildarea/3.x.ware-debian-x86.nondebug/build/Lib/contextlib.py"�[0m, line �[35m85�[0m, in �[35minner�[0m
    return func(*args, **kwds)
  File �[35m"/buildbot/buildarea/3.x.ware-debian-x86.nondebug/build/Lib/test/_test_multiprocessing.py"�[0m, line �[35m577�[0m, in �[35m_kill_process�[0m
    self.assertEqual(�[31mjoin�[0m�[1;31m()�[0m, None)
                     �[31m~~~~�[0m�[1;31m^^�[0m
  File �[35m"/buildbot/buildarea/3.x.ware-debian-x86.nondebug/build/Lib/test/_test_multiprocessing.py"�[0m, line �[35m250�[0m, in �[35m__call__�[0m
    return �[31mself.func�[0m�[1;31m(*args, **kwds)�[0m
           �[31m~~~~~~~~~�[0m�[1;31m^^^^^^^^^^^^^^^�[0m
  File �[35m"/buildbot/buildarea/3.x.ware-debian-x86.nondebug/build/Lib/multiprocessing/process.py"�[0m, line �[35m156�[0m, in �[35mjoin�[0m
    res = self._popen.wait(timeout)
  File �[35m"/buildbot/buildarea/3.x.ware-debian-x86.nondebug/build/Lib/multiprocessing/popen_fork.py"�[0m, line �[35m44�[0m, in �[35mwait�[0m
    return �[31mself.poll�[0m�[1;31m(os.WNOHANG if timeout == 0.0 else 0)�[0m
           �[31m~~~~~~~~~�[0m�[1;31m^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^�[0m
  File �[35m"/buildbot/buildarea/3.x.ware-debian-x86.nondebug/build/Lib/multiprocessing/popen_fork.py"�[0m, line �[35m28�[0m, in �[35mpoll�[0m
    pid, sts = �[31mos.waitpid�[0m�[1;31m(self.pid, flag)�[0m
               �[31m~~~~~~~~~~�[0m�[1;31m^^^^^^^^^^^^^^^^�[0m
  File �[35m"/buildbot/buildarea/3.x.ware-debian-x86.nondebug/build/Lib/test/_test_multiprocessing.py"�[0m, line �[35m573�[0m, in �[35mhandler�[0m
    raise RuntimeError('join took too long: %s' % p)
�[1;35mRuntimeError�[0m: �[35mjoin took too long: <Process name='Process-159' pid=23294 parent=22521 started daemon>�[0m

@sergey-miryanov sergey-miryanov mentioned this pull request Oct 22, 2025
Merged
StanFromIreland pushed a commit to StanFromIreland/cpython that referenced this pull request Dec 6, 2025
@sergey-miryanov @StanFromIreland
pythonGH-139193: Fix dump_stack when PYTHON_LLTRACE=4 (pythonGH-139384)
a5a5687
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Fidget-Spinner Fidget-Spinner Fidget-Spinner approved these changes

@markshannon markshannon Awaiting requested review from markshannon markshannon is a code owner

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@sergey-miryanov @markshannon @bedevere-bot @Fidget-Spinner