bpo-26836: Add os.memfd_create()#13567
Conversation
tiran
left a comment
There was a problem hiding this comment.
Good work! 👍
Please modify the patch to use the glibc wrapper instead of the syscall interface and to use MFD_CLOEXEC as default value for the new FD. Feel free to use bits and pieces from my pending PR master...tiran:bpo-26836-memfd-seal (Co-authored-by appreciated).
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
|
Thank you, @tiran, for the comments. I will address them soon. |
Co-Authored-By: Christian Heimes <[email protected]>
|
There were some issues with I have made the requested changes; please review again. |
|
Thanks for making the requested changes! @tiran: please review the changes made to this pull request. |
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
|
I have made the requested changes; please review again. |
|
Thanks for making the requested changes! @tiran: please review the changes made to this pull request. |
|
@tiran: Please replace |
|
Argh, I wanted to edit the commit message, too. Thanks for your hard work. Is there a PR for sealing, too? |
|
|
@ZackerySpytz Please see buildbot logs. It looks like some HUGE TABLE constants are not defined on all platforms. You may have to ifdef them all :( |
|
@tiran Okay, I'll take a look. |
* bpo-26836: Add os.memfd_create() * Use the glibc wrapper for memfd_create() Co-Authored-By: Christian Heimes <[email protected]> * Fix deletions caused by autoreconf. * Use MFD_CLOEXEC as the default value for *flags*. * Add memset_s to configure.ac. * Revert memset_s changes. * Apply the requested changes. * Tweak the docs.
https://bugs.python.org/issue26836