Revert "gh-96471: Add shutdown() method to queue.Queue (#104750)"#115265
Revert "gh-96471: Add shutdown() method to queue.Queue (#104750)"#115265gvanrossum wants to merge 1 commit intopython:mainfrom
Conversation
…104750)" Reason for the revert: python#115258 test_queue timed out on Windows free-threading build. The PR author had mentioned this in python#104750 (comment) but I forgot about it and merged anyway. This reverts commit b2d9d13.
|
@EpicWink Just letting you know your PR might be reverted. Don't worry, we can resubmit we disable the offending test. We may also be able to avoid reverting the whole PR by just disabling that test, if we're convinced the problem is restricted to the combination of free-threading, Windows, and that specific test. |
|
After reviewing the added code, I suggest immediately reverting the failing test on Windows free-thread builds to stop interfering with good PRs, and monitor for other CI/buildbot failures, while investigating. I was thinking about debug prints but then saw the note on the original PR that they themselves cause failures. EDIT: side note line 241: n_items is not used in this function as _qsize is re-called each loop. |
|
Closing in favor of #115269 which disables the offending tests on Windows. |
2 participants
Reason for the revert: #115258 test_queue timed out on Windows free-threading build.
The PR author had mentioned this in
#104750 (comment) but I forgot about it and merged anyway.
This reverts commit b2d9d13.
📚 Documentation preview 📚: https://cpython-previews--115265.org.readthedocs.build/