GH-113710: Improve _SET_IP and _CHECK_VALIDITY#115248
Merged
markshannon merged 9 commits intopython:mainfrom Feb 13, 2024
Merged
GH-113710: Improve _SET_IP and _CHECK_VALIDITY#115248markshannon merged 9 commits intopython:mainfrom
_SET_IP and _CHECK_VALIDITY#115248markshannon merged 9 commits intopython:mainfrom
Conversation
Closed
Member
Author
|
Stats and performance show a ~2% speedup (which seems high, so is probably mostly noise) but some meaningful improvement in the stats:
|
Contributor
Yes, and the HPT result confirms your hunch that it's mostly noise: 1.00x faster at 99th %ile |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
_SET_IPto take the pointer as its operand, saving a couple of machine instructions_CHECK_VALIDITY_AND_SET_IP"super micro op"_SET_IPand_CHECK_VALIDITY.The
_CHECK_VALIDITY_AND_SET_IP"super micro op" isn't that useful at runtime as_SET_IPis needed before an escaping instruction, and_CHECK_VALIDITYis needed after an escaping instruction, so they tend to be independent.However, it means that half of the uop buffer is useful instructions rather than a third.