gh-102859: Remove JUMP_IF_FALSE_OR_POP and JUMP_IF_TRUE_OR_POP#102870
Merged
iritkatriel merged 9 commits intopython:mainfrom Mar 22, 2023
Merged
gh-102859: Remove JUMP_IF_FALSE_OR_POP and JUMP_IF_TRUE_OR_POP#102870iritkatriel merged 9 commits intopython:mainfrom
iritkatriel merged 9 commits intopython:mainfrom
Conversation
Member
Author
|
There's still a problem with the peepholer. Converting to draft. |
carljm
approved these changes
Mar 21, 2023
Member
Author
|
Thanks, I’ll wait for benchmark results before merging. |
markshannon
approved these changes
Mar 22, 2023
Member
markshannon
left a comment
markshannon
left a comment
There was a problem hiding this comment.
I would expect this to cause a slowdown, but it seems the slowdown is negligible.
I expect that we will be able to get all that back and more with the optimizations discussed in the issue.
iritkatriel
added
interpreter-core
|
🤖 New build scheduled with the buildbot fleet by @iritkatriel for commit b2bf829 🤖 If you want to schedule another build, you need to add the 🔨 test-with-refleak-buildbots label again. |
bedevere-bot
removed
the
🔨 test-with-refleak-buildbots
Member
Author
|
refleak check passed. |
Fidget-Spinner
pushed a commit
to Fidget-Spinner/cpython
that referenced
this pull request
Mar 27, 2023
warsaw
pushed a commit
to warsaw/cpython
that referenced
this pull request
Apr 11, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #102859 .