Issue #8848: U / U# formats of Py_BuildValue() are just alias to s / s#

Victor Stinner · Victor Stinner · commit 7eeb5b5e5017 · 2010-06-07T19:57:46.000Z
diff --git a/Doc/c-api/arg.rst b/Doc/c-api/arg.rst
@@ -530,12 +530,10 @@ Building values
       and ``None`` is returned.
 
    ``U`` (string) [char \*]
-      Convert a null-terminated C string to a Python unicode object. If the C string
-      pointer is *NULL*, ``None`` is used.
+      Same as ``s``.
 
    ``U#`` (string) [char \*, int]
-      Convert a C string and its length to a Python unicode object. If the C string
-      pointer is *NULL*, the length is ignored and ``None`` is returned.
+      Same as ``s#``.
 
    ``i`` (integer) [int]
       Convert a plain C :ctype:`int` to a Python integer object.
diff --git a/Modules/_ctypes/_ctypes.c b/Modules/_ctypes/_ctypes.c
@@ -4467,7 +4467,7 @@ PyCArrayType_from_ctype(PyObject *itemtype, Py_ssize_t length)
 #endif
 
     result = PyObject_CallFunction((PyObject *)&PyCArrayType_Type,
-                                   "U(O){s:n,s:O}",
+                                   "s(O){s:n,s:O}",
                                    name,
                                    &PyCArray_Type,
                                    "_length_",
diff --git a/Objects/exceptions.c b/Objects/exceptions.c
@@ -1510,7 +1510,7 @@ PyUnicodeEncodeError_Create(
     const char *encoding, const Py_UNICODE *object, Py_ssize_t length,
     Py_ssize_t start, Py_ssize_t end, const char *reason)
 {
-    return PyObject_CallFunction(PyExc_UnicodeEncodeError, "Uu#nnU",
+    return PyObject_CallFunction(PyExc_UnicodeEncodeError, "su#nns",
                                  encoding, object, length, start, end, reason);
 }
 
@@ -1625,7 +1625,7 @@ PyUnicodeDecodeError_Create(
     assert(length < INT_MAX);
     assert(start < INT_MAX);
     assert(end < INT_MAX);
-    return PyObject_CallFunction(PyExc_UnicodeDecodeError, "Uy#nnU",
+    return PyObject_CallFunction(PyExc_UnicodeDecodeError, "sy#nns",
                                  encoding, object, length, start, end, reason);
 }
 
diff --git a/Python/Python-ast.c b/Python/Python-ast.c
@@ -527,7 +527,7 @@ static PyTypeObject* make_type(char *type, PyTypeObject* base, char**fields, int
         }
         PyTuple_SET_ITEM(fnames, i, field);
     }
-    result = PyObject_CallFunction((PyObject*)&PyType_Type, "U(O){sOss}",
+    result = PyObject_CallFunction((PyObject*)&PyType_Type, "s(O){sOss}",
                     type, base, "_fields", fnames, "__module__", "_ast");
     Py_DECREF(fnames);
     return (PyTypeObject*)result;
diff --git a/Python/errors.c b/Python/errors.c
@@ -679,7 +679,7 @@ PyErr_NewException(const char *name, PyObject *base, PyObject *dict)
             goto failure;
     }
     /* Create a real new-style class. */
-    result = PyObject_CallFunction((PyObject *)&PyType_Type, "UOO",
+    result = PyObject_CallFunction((PyObject *)&PyType_Type, "sOO",
                                    dot+1, bases, dict);
   failure:
     Py_XDECREF(bases);
diff --git a/Python/modsupport.c b/Python/modsupport.c
@@ -302,39 +302,7 @@ do_mkvalue(const char **p_format, va_list *p_va, int flags)
 
         case 's':
         case 'z':
-        {
-            PyObject *v;
-            char *str = va_arg(*p_va, char *);
-            Py_ssize_t n;
-            if (**p_format == '#') {
-                ++*p_format;
-                if (flags & FLAG_SIZE_T)
-                    n = va_arg(*p_va, Py_ssize_t);
-                else
-                    n = va_arg(*p_va, int);
-            }
-            else
-                n = -1;
-            if (str == NULL) {
-                v = Py_None;
-                Py_INCREF(v);
-            }
-            else {
-                if (n < 0) {
-                    size_t m = strlen(str);
-                    if (m > PY_SSIZE_T_MAX) {
-                        PyErr_SetString(PyExc_OverflowError,
-                            "string too long for Python string");
-                        return NULL;
-                    }
-                    n = (Py_ssize_t)m;
-                }
-                v = PyUnicode_FromStringAndSize(str, n);
-            }
-            return v;
-        }
-
-        case 'U':
+        case 'U':   /* XXX deprecated alias */
         {
             PyObject *v;
             char *str = va_arg(*p_va, char *);
diff --git a/Python/sysmodule.c b/Python/sysmodule.c
@@ -1510,7 +1510,7 @@ _PySys_Init(void)
                          PyLong_FromLong(PY_VERSION_HEX));
     svnversion_init();
     SET_SYS_FROM_STRING("subversion",
-                        Py_BuildValue("(UUU)", "CPython", branch,
+                        Py_BuildValue("(sss)", "CPython", branch,
                                       svn_revision));
     SET_SYS_FROM_STRING("dont_write_bytecode",
                          PyBool_FromLong(Py_DontWriteBytecodeFlag));

Original file line number	Diff line number	Diff line change
`@@ -1510,7 +1510,7 @@ PyUnicodeEncodeError_Create(`
`1510`	`1510`	`const char encoding, const Py_UNICODE object, Py_ssize_t length,`
`1511`	`1511`	`Py_ssize_t start, Py_ssize_t end, const char *reason)`
`1512`	`1512`	`{`
`1513`		`- return PyObject_CallFunction(PyExc_UnicodeEncodeError, "Uu#nnU",`
	`1513`	`+ return PyObject_CallFunction(PyExc_UnicodeEncodeError, "su#nns",`
`1514`	`1514`	`encoding, object, length, start, end, reason);`
`1515`	`1515`	`}`
`1516`	`1516`
`@@ -1625,7 +1625,7 @@ PyUnicodeDecodeError_Create(`
`1625`	`1625`	`assert(length < INT_MAX);`
`1626`	`1626`	`assert(start < INT_MAX);`
`1627`	`1627`	`assert(end < INT_MAX);`
`1628`		`- return PyObject_CallFunction(PyExc_UnicodeDecodeError, "Uy#nnU",`
	`1628`	`+ return PyObject_CallFunction(PyExc_UnicodeDecodeError, "sy#nns",`
`1629`	`1629`	`encoding, object, length, start, end, reason);`
`1630`	`1630`	`}`
`1631`	`1631`
Original file line number	Diff line number	Diff line change
`@@ -527,7 +527,7 @@ static PyTypeObject* make_type(char type, PyTypeObject base, char**fields, int`
`527`	`527`	`}`
`528`	`528`	`PyTuple_SET_ITEM(fnames, i, field);`
`529`	`529`	`}`
`530`		`- result = PyObject_CallFunction((PyObject*)&PyType_Type, "U(O){sOss}",`
	`530`	`+ result = PyObject_CallFunction((PyObject*)&PyType_Type, "s(O){sOss}",`
`531`	`531`	`type, base, "_fields", fnames, "__module__", "_ast");`
`532`	`532`	`Py_DECREF(fnames);`
`533`	`533`	`return (PyTypeObject*)result;`
Original file line number	Diff line number	Diff line change
`@@ -679,7 +679,7 @@ PyErr_NewException(const char name, PyObject base, PyObject *dict)`
`679`	`679`	`goto failure;`
`680`	`680`	`}`
`681`	`681`	`/* Create a real new-style class. */`
`682`		`- result = PyObject_CallFunction((PyObject *)&PyType_Type, "UOO",`
	`682`	`+ result = PyObject_CallFunction((PyObject *)&PyType_Type, "sOO",`
`683`	`683`	`dot+1, bases, dict);`
`684`	`684`	`failure:`
`685`	`685`	`Py_XDECREF(bases);`