Skip to content

fixed GraphCRF._set_size_joint_feature#196

Open
ShigekiKarita wants to merge 2 commits intopystruct:masterfrom
ShigekiKarita:graph-crf-fix
Open

fixed GraphCRF._set_size_joint_feature#196
ShigekiKarita wants to merge 2 commits intopystruct:masterfrom
ShigekiKarita:graph-crf-fix

Conversation

@ShigekiKarita
Copy link

@ShigekiKarita ShigekiKarita commented Jan 25, 2017 •
edited
Loading

I fixed GraphCRF._set_size_joint_feature

The problem is that size_joint_feature set a float value for its shape.
For the details, please read this log.

python plot_grid_crf.py                                                                                              [17:09:30]
Traceback (most recent call last):
  File "plot_grid_crf.py", line 26, in <module>
    clf.fit(X, Y)
  File "/home/skarita/.pyenv/versions/pystruct/lib/python3.5/site-packages/pystruct-0.2.5-py3.5-linux-x86_64.egg/pystruct/learners/
one_slack_ssvm.py", line 409, in fit
    self.w = np.zeros(self.model.size_joint_feature)
TypeError: 'float' object cannot be interpreted as an integer

@amueller
Copy link
Member

amueller commented Feb 19, 2017

Thanks. Can you please add a regression test? Currently tests are passing on Python3.4

mattfabina referenced this pull request Apr 7, 2017
@amueller
ENH user "directed" in ChainCRF, set default=True, more / better docs…
16d5eea 
…trings.
@ShigekiKarita
Copy link
Author

ShigekiKarita commented Apr 24, 2017

Hi. Is there any example or existing regression test?

@ShigekiKarita ShigekiKarita mentioned this pull request Apr 24, 2017
Closed
@adamklec
Copy link

adamklec commented Jul 17, 2018

Just ran into this. Would it be possible to merge the fix without a regression test?

@jlmeunier
Copy link
Collaborator

jlmeunier commented Jul 19, 2018

Hi,
it'll be fixed in the coming release.
JL

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ShigekiKarita @amueller @adamklec @jlmeunier