Skip to content

Enforce consistent logic in ackermannization test #732

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
marcogario wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Enforce consistent logic in ackermannization test #732

marcogario wants to merge 1 commit into from

Conversation

@marcogario
Copy link
Contributor

@marcogario marcogario commented Jul 31, 2022

Pass logic to _verify_ackermannization so we can check for preconditions there and ensure we use the same logic throughout the test.

Fixes #731

@marcogario
Enforce consistent logic in ackermannization test
b36bf56 
Pass logic to _verify_ackermannization so we can check for preconditions
there and ensure we use the same logic throughout the test.

Fixes #731
@marcogario marcogario requested a review from mikand July 31, 2022 09:07
mikand
mikand approved these changes Aug 16, 2022
View reviewed changes
Copy link
Contributor

@mikand mikand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mikand mikand mikand approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

test_ackermannization_for_examples failure

3 participants

@marcogario @mikand