Conversation
|
Hello again! Thank you for this new pull request 🤩. Please begin by requesting your checklist using the command |
|
Here is your checklist. Please tick items off when you have completed them or determined that they are not necessary for this pull request:
|
|
/bot run docs coverage |
![pyccel-bot[bot]](https://avatars.githubusercontent.com/in/364561?s=60&v=4){kind=small}
There was a problem hiding this comment.
There seems to be lines in this PR which aren't tested. Please take a look at my comments and add tests which cover the new code.
If this is modified code which cannot be easily tested in this PR please open an issue to request that this code be either removed or tested. Once you have done that please leave a message on the relevant conversation beginning with the line /bot accept and referencing the issue.
Similarly if the new code cannot be tested for some reason, please leave a comment beginning with the line /bot accept on the relevant conversation explaining why the code can't be tested.
| return code | ||
| else: | ||
| # code ends with \n |
There was a problem hiding this comment.
This code isn't tested. Please can you take a look
| lhs = ObjectAddress(expr.lhs) if isinstance(expr.lhs, Variable) else expr.lhs | ||
| rhs = ObjectAddress(expr.rhs) if isinstance(expr.rhs, Variable) else expr.rhs | ||
|
|
||
| lhs_code = self._print(lhs) | ||
| rhs_code = self._print(rhs) | ||
| return f'{lhs_code} {Op} {rhs_code}' | ||
|
|
There was a problem hiding this comment.
This code isn't tested. Please can you take a look
| return '' | ||
|
|
There was a problem hiding this comment.
This code isn't tested. Please can you take a look
| self.scope.get_temporary_variable, self.scope, | ||
| language_has_vectors = False) | ||
| else: | ||
| body_exprs = expr.body |
There was a problem hiding this comment.
This code isn't tested. Please can you take a look
| return 'return;\n' | ||
|
|
There was a problem hiding this comment.
This code isn't tested. Please can you take a look
| desc_5 = "Run the single-process tests which can be run in parallel... [language: C++]" | ||
| desc_6 = "Run the single-process tests which can be run in parallel... [language: Python]" | ||
| descriptions = [desc_1, desc_2, desc_3, desc_4, desc_5, desc_6] |
There was a problem hiding this comment.
This code isn't tested. Please can you take a look
| cmd_5 = ['-ra', '-m (not xdist_incompatible and cpp)', '-n', 'auto'] | ||
| cmd_6 = ['-ra', '-m (not xdist_incompatible and python)', '-n', 'auto'] | ||
| commands = [cmd_1, cmd_2, cmd_3, cmd_4, cmd_5, cmd_6] |
There was a problem hiding this comment.
This code isn't tested. Please can you take a look
| assert context in ('module', 'function', 'class', 'variable', 'wrapper') | ||
| assert parent_context in ('module', 'function', 'class', 'loop', 'program') | ||
| if len(name)>4 and all(name[i] == '_' for i in (0,1,-1,-2)) and parent_context == 'class': | ||
| return name |
There was a problem hiding this comment.
This code isn't tested. Please can you take a look
| if name == '__del__': | ||
| name = 'free' | ||
| if len(name)>4 and all(name[i] == '_' for i in (0,1,-1,-2)): | ||
| name = 'operator' + name[1:-2] |
There was a problem hiding this comment.
This code isn't tested. Please can you take a look
| name = 'private'+name | ||
| return self._get_collisionless_name(name, symbols) |
There was a problem hiding this comment.
This code isn't tested. Please can you take a look
EmilyBourne
added
the
blocked
1 participant
To be reviewed and merged after #2525. This is work towards adding support for C++ as described in #2393.