Skip to content

feat: spinup preview environment on open/reopen#86

Merged
crohr merged 1 commit into
pullpreview:masterfrom
Alanoll:feat/spinup-preview-on-open
Aug 24, 2024
Merged

feat: spinup preview environment on open/reopen#86
crohr merged 1 commit into
pullpreview:masterfrom
Alanoll:feat/spinup-preview-on-open

Conversation

@Alanoll

@Alanoll Alanoll commented Aug 23, 2024

Copy link
Copy Markdown
Contributor

My attempt at a solution for #85 .

It looked like the process already performs an octokit api call to get the PullRequest's latest version. I just added two more checks to when return pr_up.

@crohr

crohr commented Aug 24, 2024

Copy link
Copy Markdown
Member

Thanks, but I thought you wanted to do launch a preview even if the label is not present? Currently there is still the pr_has_label? check.

Edit: oh ok I see what you mean, I'm going to test this, thanks!

@crohr crohr self-assigned this Aug 24, 2024
@crohr crohr added the pullpreview This label allows to start a PullPreview environment label Aug 24, 2024
@crohr crohr merged commit 422123d into pullpreview:master Aug 24, 2024
@github-actions github-actions Bot removed the pullpreview This label allows to start a PullPreview environment label Aug 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants