Make processing-java return an error code if the VM failed

gohai · gohai · commit 6315a2f3da34 · 2015-08-15T16:01:37.000+02:00
This still doesn't seem to return anything for exceptions inside a sketch, but a start. Error codes could be helpful for automatic regression testing of all examples.
diff --git a/java/src/processing/mode/java/Commander.java b/java/src/processing/mode/java/Commander.java
@@ -275,6 +275,7 @@ public Commander(String[] args) {
               } else {
                 runner.launch(sketchArgs);
               }
+              success = !runner.vmReturnedError();
             }
           } else {
             success = false;
diff --git a/java/src/processing/mode/java/runner/Runner.java b/java/src/processing/mode/java/runner/Runner.java
@@ -59,6 +59,7 @@ public class Runner implements MessageConsumer {
 
   // Running remote VM
   protected VirtualMachine vm;
+  protected boolean vmReturnedError;
 
   // Thread transferring remote error stream to our error stream
   protected Thread errThread = null;
@@ -130,6 +131,14 @@ public VirtualMachine present(String[] args) {
   }
 
 
+  /**
+   * Whether the last invocation of launchJava() was successful or not
+   */
+  public boolean vmReturnedError() {
+    return vmReturnedError;
+  }
+
+
   /**
    * Simple non-blocking launch of the virtual machine. VM starts suspended.
    * @return debuggee VM or null on failure
@@ -408,6 +417,7 @@ protected void launchJava(final String[] args) {
     new Thread(new Runnable() {
       public void run() {
 //        PApplet.println("java starting");
+        vmReturnedError = false;
         process = PApplet.exec(args);
         try {
 //          PApplet.println("java waiting");
@@ -445,6 +455,7 @@ public void run() {
             // changing this to separate editor and listener [091124]
             //if (editor != null) {
             listener.statusError("Could not run the sketch.");
+            vmReturnedError = true;
             //}
 //            return null;
           }

Original file line number	Diff line number	Diff line change
`@@ -275,6 +275,7 @@ public Commander(String[] args) {`
`275`	`275`	`} else {`
`276`	`276`	`runner.launch(sketchArgs);`
`277`	`277`	`}`
	`278`	`+ success = !runner.vmReturnedError();`
`278`	`279`	`}`
`279`	`280`	`} else {`
`280`	`281`	`success = false;`