fix setModified() so that OpenGL updates properly (#1786)

benfry · benfry · commit dfa233b443f7 · 2013-06-02T14:09:55.000-04:00
diff --git a/core/src/processing/core/PGraphicsJava2D.java b/core/src/processing/core/PGraphicsJava2D.java
@@ -359,7 +359,10 @@ public void endDraw() {
 //    // full copy of the pixels to the surface in this.updatePixels().
 //    setModified();
 //    super.updatePixels();
-    setModified();  // marks pixels as modified so that the pixels will be updated
+
+    // Marks pixels as modified so that the pixels will be updated.
+    // Also sets mx1/y1/x2/y2 so that OpenGL will pick it up.
+    setModified();
   }
 
 
diff --git a/core/src/processing/core/PImage.java b/core/src/processing/core/PImage.java
@@ -416,6 +416,10 @@ public boolean isModified() {  // ignore
 
   public void setModified() {  // ignore
     modified = true;
+    mx1 = 0;
+    my1 = 0;
+    mx2 = width;
+    my2 = height;
   }
 
 
diff --git a/core/todo.txt b/core/todo.txt
@@ -9,6 +9,8 @@ X .png data written when .jpg file specified with save/saveFrame()
 X   https://github.com/processing/processing/issues/1810
 X remove() broken in the List classes
 X   https://github.com/processing/processing/issues/1826
+X Java2D surfaces not updating when used with OpenGL
+X   https://github.com/processing/processing/issues/1786
 
 andres
 A PImage not drawn after resize()/get() in P2D/P3D

Original file line number	Diff line number	Diff line change
`@@ -416,6 +416,10 @@ public boolean isModified() { // ignore`
`416`	`416`
`417`	`417`	`public void setModified() { // ignore`
`418`	`418`	`modified = true;`
	`419`	`+ mx1 = 0;`
	`420`	`+ my1 = 0;`
	`421`	`+ mx2 = width;`
	`422`	`+ my2 = height;`
`419`	`423`	`}`
`420`	`424`
`421`	`425`